contrib/ck: keep dcas parameters thin under bounds-safety
AcceptedPublic
Actions

Authored by abhijeetsharma2002_gmail.com on Wed, Aug 19, 12:03 PM.

Details

Reviewers

rpaulo
emaste
andrew

Summary

Under -fbounds-safety a uint64_t [2] parameter becomes a bounds-carrying
pointer, which cannot be an inline assembly operand. Plain uint64_t * is
identical in C and carries no bound. Vendor declarations stay in the
#else for the next CK import.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75739
Build 72622: arc lint + arc unit

Event Timeline

abhijeetsharma2002_gmail.com created this revision.Wed, Aug 19, 12:03 PM

Herald added a reviewer: andrew. · View Herald TranscriptWed, Aug 19, 12:03 PM

Herald added a subscriber: imp. · View Herald Transcript

abhijeetsharma2002_gmail.com requested review of this revision.Wed, Aug 19, 12:03 PM

Harbormaster completed remote builds in B75739: Diff 184353.Wed, Aug 19, 12:03 PM

abhijeetsharma2002_gmail.com added a parent revision: D58985: sys: build core headers under bounds-safety.Wed, Aug 19, 12:03 PM

abhijeetsharma2002_gmail.com added a child revision: D58987: kern: add bounds-safety soft-trap runtime.

rpaulo added inline comments.Thu, Aug 27, 10:41 PM

sys/contrib/ck/include/gcc/aarch64/ck_pr_llsc.h
42	Wouldn’t this work?

abhijeetsharma2002_gmail.com added inline comments.Fri, Sep 4, 3:29 AM

sys/contrib/ck/include/gcc/aarch64/ck_pr_llsc.h
42	Hey, unfortunately not. The issue is that any pointer with bounds cannot be used with inline assembly.

rpaulo accepted this revision.Sat, Sep 5, 12:15 AM

This revision is now accepted and ready to land.Sat, Sep 5, 12:15 AM

Revision Contents
Changeset List

Path

Size

sys/

contrib/

ck/

include/

gcc/

aarch64/

ck_pr_llsc.h

16 lines

x86_64/

ck_pr.h

25 lines

Diff 184353

View Options

sys/contrib/ck/include/gcc/aarch64/ck_pr_llsc.h