Differential D58943

tools/build: stage stdckdint.h's dependencies for non-FreeBSD hosts
ClosedPublic
Actions

Authored by abhijeetsharma2002_gmail.com on Wed, Aug 19, 4:16 AM.

Tags

None

Referenced Files

	F167515274: D58943.id.diff
	Sat, Aug 22, 10:09 AM

	Unknown Object (File)
	Fri, Aug 21, 12:34 PM

	Unknown Object (File)
	Wed, Aug 19, 12:28 PM

	Unknown Object (File)
	Wed, Aug 19, 12:27 PM

	Unknown Object (File)
	Wed, Aug 19, 12:27 PM

	Unknown Object (File)
	Wed, Aug 19, 12:19 PM

	Unknown Object (File)
	Wed, Aug 19, 5:09 AM

Subscribers

Details

Reviewers

rpaulo
emaste
markj

Commits

rG805c5004fa86: tools/build: stage stdckdint.h's dependencies for non-FreeBSD hosts

Summary

37bd69d43c7 gave stdckdint.h two new includes, <sys/_visible.h> and <sys/ckdint.h>. Neither reaches a non-FreeBSD host: _visible.h is staged only under ${.MAKE.OS} == "FreeBSD" and ckdint.h is not staged at all, so the libc bootstrap fails on reallocarray.o when cross-building from macOS. Both headers are self-contained; stage them alongside stdckdint.h.

Fixes: 37bd69d43c7 ("sys: Add sys/ckdint.h")
MFC with: 37bd69d43c7 ("sys: Add sys/ckdint.h")
Sponsored by: The FreeBSD Foundation

Test Plan

Cross-build from macOS/arm64. Before: clean obj, kernel-toolchain fails with "stdckdint.h:10: fatal error: 'sys/_visible.h' file not found".
After: clean kernel-toolchain + buildkernel succeeds.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

abhijeetsharma2002_gmail.com created this revision.Wed, Aug 19, 4:16 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 4:16 AM

abhijeetsharma2002_gmail.com requested review of this revision.Wed, Aug 19, 4:16 AM

rpaulo accepted this revision.Wed, Aug 19, 5:06 AM

This revision is now accepted and ready to land.Wed, Aug 19, 5:06 AM

abhijeetsharma2002_gmail.com added a child revision: D58983: cdefs: add bounds-safety annotation macros.Wed, Aug 19, 11:57 AM

BTW, it is redundant to specify Fixes: and MFC-with:. Fixes: by itself is fine.

Closed by commit rG805c5004fa86: tools/build: stage stdckdint.h's dependencies for non-FreeBSD hosts (authored by abhijeetsharma2002_gmail.com, committed by markj). · Explain WhyWed, Aug 19, 12:24 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG805c5004fa86: tools/build: stage stdckdint.h's dependencies for non-FreeBSD hosts.

In D58943#1352888, @markj wrote:

BTW, it is redundant to specify Fixes: and MFC-with:. Fixes: by itself is fine.

Got it. Will keep it in mind for the future.

Revision Contents
Changeset List

Path

Size

tools/

build/

4 lines

Diff 184356

tools/build/Makefile

Loading...