java/openjdk8 + 11: Remove USE_LDCONFIG from ports
ClosedPublic
Actions

Authored by haraldei on Fri, Aug 14, 10:24 AM.

Details

Reviewers

jrm
emaste
glewis

Commits

R11:9477c9da0a43: java/openjdk{8,11}: Remove USE_LDCONFIG from ports

Summary

OpenJDK loads the JVM and other JDK libraries explicitly from the
correct directories, so there's no need for adding them to ldconfig.

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=297282
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75585
Build 72468: arc lint + arc unit

Event Timeline

haraldei requested review of this revision.Fri, Aug 14, 10:24 AM

haraldei created this revision.

Harbormaster completed remote builds in B75585: Diff 184040.Fri, Aug 14, 10:24 AM

This looks good to me. One nit: In the commit log, PR: expects only the bug number to automatically update the bug, not the full URL.

This revision is now accepted and ready to land.Fri, Aug 14, 5:01 PM

In D58841#1350374, @jrm wrote:

One nit: In the commit log, PR: expects only the bug number to automatically update the bug, not the full URL.

Thanks, I'll fix before pushing.

The patch is rejected because of the subject line: "java/openjdk8 + 11: ..." Should I split it in two, or is there an established way of marking that it affects more than one port?

It's probably the spaces before the : catching the subject line hook. You could either get rid of those spaces, or use java/openjdk{8,11}: Remove USE_LDCONFIG from ports, which is a format I see in the logs.

Closed by commit R11:9477c9da0a43: java/openjdk{8,11}: Remove USE_LDCONFIG from ports (authored by haraldei). · Explain WhyMon, Aug 17, 10:26 AM

This revision was automatically updated to reflect the committed changes.

haraldei added a commit: R11:9477c9da0a43: java/openjdk{8,11}: Remove USE_LDCONFIG from ports.

In D58841#1350633, @jrm wrote:

It's probably the spaces before the : catching the subject line hook. You could either get rid of those spaces, or use java/openjdk{8,11}: Remove USE_LDCONFIG from ports, which is a format I see in the logs.

Thanks! That makes sense, and seemed to work :)

This change broke build of databases/sqldeveloper in poudriere:
https://pkg-status.freebsd.org/beefy23/data/150amd64-default/0c6548094723/logs/sqldeveloper-24.3.1.347.1826_3.log

In D58841#1352268, @vvd wrote:

This change broke build of databases/sqldeveloper in poudriere:
https://pkg-status.freebsd.org/beefy23/data/150amd64-default/0c6548094723/logs/sqldeveloper-24.3.1.347.1826_3.log

Ooops, that wasn't intended, I'm looking into it!