Differential D58766

vm_object: Augment an assertion in vm_object_split()
ClosedPublic
Actions

Authored by markj on Mon, Aug 10, 5:47 PM.

Tags

None

Referenced Files

	F169762322: D58766.id183877.diff
	Wed, Sep 2, 11:59 AM

	F169715767: D58766.id183813.diff
	Wed, Sep 2, 9:01 AM

	F169699064: D58766.diff
	Wed, Sep 2, 8:01 AM

	Unknown Object (File)
	Mon, Aug 31, 6:33 AM

	Unknown Object (File)
	Mon, Aug 31, 6:06 AM

	Unknown Object (File)
	Mon, Aug 31, 3:08 AM

	Unknown Object (File)
	Mon, Aug 31, 2:00 AM

	Unknown Object (File)
	Mon, Aug 31, 2:00 AM

View All 41 Files

Subscribers

Details

Reviewers

alc
kib

Commits

rG1b4e0a4467f9: vm_object: Augment an assertion in vm_object_split()
rG12857d8f4269: vm_object: Augment an assertion in vm_object_split()

Summary

In some private discussion it was pointed out that vm_object_split()'s
pattern of dropping the source object lock looks dangerous in that the
initial assumption that OBJ_ONEMAPPING is set may become false. In
practice I believe that the map lock holds this flag stable, but let's
assert that.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mon, Aug 10, 5:47 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Aug 10, 5:47 PM

markj requested review of this revision.Mon, Aug 10, 5:47 PM

Harbormaster completed remote builds in B75496: Diff 183813.Mon, Aug 10, 5:47 PM

kib accepted this revision.Mon, Aug 10, 5:58 PM

This revision is now accepted and ready to land.Mon, Aug 10, 5:58 PM

alc accepted this revision.Tue, Aug 11, 8:43 AM

Closed by commit rG12857d8f4269: vm_object: Augment an assertion in vm_object_split() (authored by markj). · Explain WhyTue, Aug 11, 2:24 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG12857d8f4269: vm_object: Augment an assertion in vm_object_split().

markj added a commit: rG1b4e0a4467f9: vm_object: Augment an assertion in vm_object_split().Mon, Aug 24, 4:30 PM

Revision Contents
Changeset List

Path

Size

sys/

vm/

5 lines

Diff 183877

sys/vm/vm_object.c

Loading...