Author: Faraz Vahedi <kfv@FreeBSD.org>
Date: Fri Aug 7 14:02:11 2026 +0330
Add new src committer (kfv)
Complete steps 1-4 as per Committer's Guide §7.1.
Reviewed by: dteske, fuz
Approved by: dteske (mentor), fuz (mentor)
Differential Revision: https://reviews.freebsd.org/D58699Details
Details
- Reviewers
dteske fuz - Commits
- R9:86fc1fe1f6d3: Add new src committer (kfv)
Diff Detail
Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 75438 Build 72321: arc lint + arc unit
Event Timeline
Comment Actions
I'll update the patch with the required metadata fields once it's approved.
Please let me know if there's anything else that needs to be addressed.
Thanks!
Comment Actions
LGTM.
Please post the commit message you plan to use so I can then give approval for commit.
Comment Actions
I have included dteske's approval in place since she's aware of the revision; I can update it if necessary later.
Comment Actions
Commit message looks workable.
Has @dteske reviewed or approved of this DR? I don't see it anywhere. In any case, adjust the commit message to reflect who actually reviewed and gave approval when you land.
That said, note that the (mentor) is about approval for commit, not code review. I'm reviewing this changeset as a contributor, not as your mentor, so there doesn't need to be a (mentor) in the Reviewed by: line.
Comment Actions
Has @dteske reviewed or approved of this DR? I don't see it anywhere. In any case, adjust the commit message to reflect who actually reviewed and gave approval when you land.
Not yet here, but we've discussed it. I'll update the commit message accordingly if her review and approval are not recorded here before we land it.
That said, note that the (mentor) is about approval for commit, not code review. I'm reviewing this changeset as a contributor, not as your mentor, so there doesn't need to be a (mentor) in the Reviewed by: line.
Thanks for the clarification. I'll keep that in mind and update the Reviewed by: line again before landing.
Comment Actions
Looks good to my eyes. Please update the summary to include proposed commit message (is how I was mentored -- it was a long time ago, but I agreed that it was good to give mentors a preview of what was to land so they could head-off any potential criticism since the commit itself is sent to every committer while the review is narrow in scope to who sees it)
Comment Actions
@fuz: I don't have access to the doc repository. Am I expected to handle this myself, or do we need a doc committer to take care of it on our behalf?
Comment Actions
You should have commit access to the doc repository and are permitted to touch these files (cf. § 4.1.1 Committer's Guide). If that doesn't work something went wrong setting up your commit bit.
Comment Actions
I just checked the internal/admin branch, and it’s most likely due to the missing entry in the mentors file.
I just discussed it with Devin, too. I’ll try pushing again once access is granted.
Thanks!
Comment Actions
The news.toml file is in reverse chronological order, so after rebasing I placed mine before the most recent 14.5-BETA1 announcement as it is six days after my joining date. Is that correct?
Comment Actions
OK, I’ve taken a look at similar cases throughout the file and reviewed the commit history, and it sounds like I’ve got it right. Ready to push these changes shortly.