Page MenuHomeFreeBSD
Differential D7014

hyperv/vmbus: Make channel id a field of hv_vmbus_channel.
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Jun 29 2016, 3:22 AM.
Tags
None
Referenced Files
F115204246: D7014.diff
Mon, Apr 21, 10:06 AM
Unknown Object (File)
Mon, Apr 21, 4:28 AM
Unknown Object (File)
Mon, Apr 21, 4:05 AM
Unknown Object (File)
Mon, Apr 21, 3:45 AM
Unknown Object (File)
Mon, Apr 21, 3:16 AM
Unknown Object (File)
Mon, Apr 21, 2:44 AM
Unknown Object (File)
Mon, Apr 21, 2:35 AM
Unknown Object (File)
Mon, Apr 21, 2:31 AM
View All 69 Files
Subscribers
None

Details

Reviewers
howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger
Commits
rS302693: hyperv/vmbus: Make channel id a field of hv_vmbus_channel.
Summary

This prepares to remove the unnecessary offer message embedding in hv_vmbus_channel.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 17994.Jun 29 2016, 3:22 AM
sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Make channel id a field of hv_vmbus_channel..
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sepherosa_gmail.com added reviewers: delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
Closed by commit rS302693: hyperv/vmbus: Make channel id a field of hv_vmbus_channel. (authored by sephe). · Explain WhyJul 13 2016, 3:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
hyperv/
include/
1 line
netvsc/
4 lines
vmbus/
50 lines
19 lines

Diff 18349

View Options

head/sys/dev/hyperv/include/hyperv.h

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines object = vm_object_allocate_dyn(tmpfs_pager_type, size,
OBJ_COLORED | OBJ_SWAP); OBJ_COLORED | OBJ_SWAP);
if (!swap_pager_init_object(object, NULL, NULL, size, 0)) { if (!swap_pager_init_object(object, NULL, NULL, size, 0)) {
vm_object_deallocate(object); vm_object_deallocate(object);
object = NULL; object = NULL;
} }
return (object); return (object);
} }
/*
* Make sure tmpfs vnodes with writable mappings can be found on the lazy list.
*
* This allows for periodic mtime updates while only scanning vnodes which are
* plausibly dirty, see tmpfs_update_mtime_lazy.
*/
static void static void
tmpfs_pager_writecount_recalc(vm_object_t object, vm_offset_t old,
vm_offset_t new)
{
struct vnode *vp;
VM_OBJECT_ASSERT_WLOCKED(object);
vp = object->un_pager.swp.swp_tmpfs;
/*
* Forced unmount?
*/
if (vp == NULL) {
KASSERT((object->flags & OBJ_TMPFS_VREF) == 0,
("object %p with OBJ_TMPFS_VREF but without vnode", object));
VM_OBJECT_WUNLOCK(object);
return;
}
if (old == 0) {
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
("object without writtable mappings has a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
- ("object without writtable mappings has a reference"));
+ ("object without writable mappings has a reference"));
VNPASS(vp->v_usecount > 0, vp);
markj:
VNPASS(vp->v_usecount > 0, vp);
} else {
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
("object with writtable mappings does not have a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
- ("object with writtable mappings does not have a reference"));
+ ("object with writable mappings does not have a reference"));
}
if (old == new) {
markj:
mjgAuthorUnsubmitted
Done
Inline Actions

fixed locally

mjg: fixed locally
}
if (old == new) {
VM_OBJECT_WUNLOCK(object);
return;
}
if (new == 0) {
vm_object_clear_flag(object, OBJ_TMPFS_VREF);
VM_OBJECT_WUNLOCK(object);
vrele(vp);
} else {
if ((object->flags & OBJ_TMPFS_VREF) == 0) {
vref(vp);
vlazy(vp);
vm_object_set_flag(object, OBJ_TMPFS_VREF);
}
VM_OBJECT_WUNLOCK(object);
}
}
static void
tmpfs_pager_update_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
mjgAuthorUnsubmitted
Done
Inline Actions

I don't know if this assert is of any use, cargo culted this bit from the original swap pager.

mjg: I don't know if this assert is of any use, cargo culted this bit from the original swap pager.
kibUnsubmitted
Not Done
Inline Actions

It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'

kib: It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings += (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_release_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings -= (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp) tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
{ {
struct vnode *vp; struct vnode *vp;
/* /*
* Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type * Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type
* type, but not OBJ_TMPFS flag. In this case there is no * type, but not OBJ_TMPFS flag. In this case there is no
* v_writecount to adjust. * v_writecount to adjust.
Show All 15 Linestmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
if (vp_heldp != NULL) if (vp_heldp != NULL)
VM_OBJECT_RUNLOCK(object); VM_OBJECT_RUNLOCK(object);
} }
struct pagerops tmpfs_pager_ops = { struct pagerops tmpfs_pager_ops = {
.pgo_kvme_type = KVME_TYPE_VNODE, .pgo_kvme_type = KVME_TYPE_VNODE,
.pgo_alloc = tmpfs_pager_alloc, .pgo_alloc = tmpfs_pager_alloc,
.pgo_set_writeable_dirty = vm_object_set_writeable_dirty_, .pgo_set_writeable_dirty = vm_object_set_writeable_dirty_,
.pgo_update_writecount = tmpfs_pager_update_writecount,
.pgo_release_writecount = tmpfs_pager_release_writecount,
.pgo_mightbedirty = vm_object_mightbedirty_, .pgo_mightbedirty = vm_object_mightbedirty_,
.pgo_getvp = tmpfs_pager_getvp, .pgo_getvp = tmpfs_pager_getvp,
}; };
static int static int
tmpfs_node_ctor(void *mem, int size, void *arg, int flags) tmpfs_node_ctor(void *mem, int size, void *arg, int flags)
{ {
struct tmpfs_node *node; struct tmpfs_node *node;
▲ Show 20 Lines • Show All 496 Lines • ▼ Show 20 Linestmpfs_free_dirent(struct tmpfs_mount *tmp, struct tmpfs_dirent *de)
if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL) if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL)
free(de->ud.td_name, M_TMPFSNAME); free(de->ud.td_name, M_TMPFSNAME);
free(de, M_TMPFSDIR); free(de, M_TMPFSDIR);
} }
void void
tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj) tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj)
{ {
bool want_vrele;
ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject"); ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject");
if (vp->v_type != VREG || obj == NULL) if (vp->v_type != VREG || obj == NULL)
return; return;
VM_OBJECT_WLOCK(obj); VM_OBJECT_WLOCK(obj);
VI_LOCK(vp); VI_LOCK(vp);
/*
* May be going through forced unmount.
*/
want_vrele = false;
if ((obj->flags & OBJ_TMPFS_VREF) != 0) {
vm_object_clear_flag(obj, OBJ_TMPFS_VREF);
want_vrele = true;
}
kibUnsubmitted
Not Done
Inline Actions

There should be a blank line after the last line of the text where the multi-line comment applies.

kib: There should be a blank line after the last line of the text where the multi-line comment…
vm_object_clear_flag(obj, OBJ_TMPFS); vm_object_clear_flag(obj, OBJ_TMPFS);
obj->un_pager.swp.swp_tmpfs = NULL; obj->un_pager.swp.swp_tmpfs = NULL;
if (vp->v_writecount < 0) if (vp->v_writecount < 0)
vp->v_writecount = 0; vp->v_writecount = 0;
VI_UNLOCK(vp); VI_UNLOCK(vp);
VM_OBJECT_WUNLOCK(obj); VM_OBJECT_WUNLOCK(obj);
if (want_vrele) {
vrele(vp);
}
} }
/* /*
* Need to clear v_object for insmntque failure. * Need to clear v_object for insmntque failure.
*/ */
static void static void
tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg) tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg)
{ {
▲ Show 20 Lines • Show All 1,397 Lines • Show Last 20 Lines
View Options

head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines object = vm_object_allocate_dyn(tmpfs_pager_type, size,
OBJ_COLORED | OBJ_SWAP); OBJ_COLORED | OBJ_SWAP);
if (!swap_pager_init_object(object, NULL, NULL, size, 0)) { if (!swap_pager_init_object(object, NULL, NULL, size, 0)) {
vm_object_deallocate(object); vm_object_deallocate(object);
object = NULL; object = NULL;
} }
return (object); return (object);
} }
/*
* Make sure tmpfs vnodes with writable mappings can be found on the lazy list.
*
* This allows for periodic mtime updates while only scanning vnodes which are
* plausibly dirty, see tmpfs_update_mtime_lazy.
*/
static void static void
tmpfs_pager_writecount_recalc(vm_object_t object, vm_offset_t old,
vm_offset_t new)
{
struct vnode *vp;
VM_OBJECT_ASSERT_WLOCKED(object);
vp = object->un_pager.swp.swp_tmpfs;
/*
* Forced unmount?
*/
if (vp == NULL) {
KASSERT((object->flags & OBJ_TMPFS_VREF) == 0,
("object %p with OBJ_TMPFS_VREF but without vnode", object));
VM_OBJECT_WUNLOCK(object);
return;
}
if (old == 0) {
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
("object without writtable mappings has a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
- ("object without writtable mappings has a reference"));
+ ("object without writable mappings has a reference"));
VNPASS(vp->v_usecount > 0, vp);
markj:
VNPASS(vp->v_usecount > 0, vp);
} else {
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
("object with writtable mappings does not have a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
- ("object with writtable mappings does not have a reference"));
+ ("object with writable mappings does not have a reference"));
}
if (old == new) {
markj:
mjgAuthorUnsubmitted
Done
Inline Actions

fixed locally

mjg: fixed locally
}
if (old == new) {
VM_OBJECT_WUNLOCK(object);
return;
}
if (new == 0) {
vm_object_clear_flag(object, OBJ_TMPFS_VREF);
VM_OBJECT_WUNLOCK(object);
vrele(vp);
} else {
if ((object->flags & OBJ_TMPFS_VREF) == 0) {
vref(vp);
vlazy(vp);
vm_object_set_flag(object, OBJ_TMPFS_VREF);
}
VM_OBJECT_WUNLOCK(object);
}
}
static void
tmpfs_pager_update_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
mjgAuthorUnsubmitted
Done
Inline Actions

I don't know if this assert is of any use, cargo culted this bit from the original swap pager.

mjg: I don't know if this assert is of any use, cargo culted this bit from the original swap pager.
kibUnsubmitted
Not Done
Inline Actions

It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'

kib: It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings += (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_release_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings -= (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp) tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
{ {
struct vnode *vp; struct vnode *vp;
/* /*
* Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type * Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type
* type, but not OBJ_TMPFS flag. In this case there is no * type, but not OBJ_TMPFS flag. In this case there is no
* v_writecount to adjust. * v_writecount to adjust.
Show All 15 Linestmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
if (vp_heldp != NULL) if (vp_heldp != NULL)
VM_OBJECT_RUNLOCK(object); VM_OBJECT_RUNLOCK(object);
} }
struct pagerops tmpfs_pager_ops = { struct pagerops tmpfs_pager_ops = {
.pgo_kvme_type = KVME_TYPE_VNODE, .pgo_kvme_type = KVME_TYPE_VNODE,
.pgo_alloc = tmpfs_pager_alloc, .pgo_alloc = tmpfs_pager_alloc,
.pgo_set_writeable_dirty = vm_object_set_writeable_dirty_, .pgo_set_writeable_dirty = vm_object_set_writeable_dirty_,
.pgo_update_writecount = tmpfs_pager_update_writecount,
.pgo_release_writecount = tmpfs_pager_release_writecount,
.pgo_mightbedirty = vm_object_mightbedirty_, .pgo_mightbedirty = vm_object_mightbedirty_,
.pgo_getvp = tmpfs_pager_getvp, .pgo_getvp = tmpfs_pager_getvp,
}; };
static int static int
tmpfs_node_ctor(void *mem, int size, void *arg, int flags) tmpfs_node_ctor(void *mem, int size, void *arg, int flags)
{ {
struct tmpfs_node *node; struct tmpfs_node *node;
▲ Show 20 Lines • Show All 496 Lines • ▼ Show 20 Linestmpfs_free_dirent(struct tmpfs_mount *tmp, struct tmpfs_dirent *de)
if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL) if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL)
free(de->ud.td_name, M_TMPFSNAME); free(de->ud.td_name, M_TMPFSNAME);
free(de, M_TMPFSDIR); free(de, M_TMPFSDIR);
} }
void void
tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj) tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj)
{ {
bool want_vrele;
ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject"); ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject");
if (vp->v_type != VREG || obj == NULL) if (vp->v_type != VREG || obj == NULL)
return; return;
VM_OBJECT_WLOCK(obj); VM_OBJECT_WLOCK(obj);
VI_LOCK(vp); VI_LOCK(vp);
/*
* May be going through forced unmount.
*/
want_vrele = false;
if ((obj->flags & OBJ_TMPFS_VREF) != 0) {
vm_object_clear_flag(obj, OBJ_TMPFS_VREF);
want_vrele = true;
}
kibUnsubmitted
Not Done
Inline Actions

There should be a blank line after the last line of the text where the multi-line comment applies.

kib: There should be a blank line after the last line of the text where the multi-line comment…
vm_object_clear_flag(obj, OBJ_TMPFS); vm_object_clear_flag(obj, OBJ_TMPFS);
obj->un_pager.swp.swp_tmpfs = NULL; obj->un_pager.swp.swp_tmpfs = NULL;
if (vp->v_writecount < 0) if (vp->v_writecount < 0)
vp->v_writecount = 0; vp->v_writecount = 0;
VI_UNLOCK(vp); VI_UNLOCK(vp);
VM_OBJECT_WUNLOCK(obj); VM_OBJECT_WUNLOCK(obj);
if (want_vrele) {
vrele(vp);
}
} }
/* /*
* Need to clear v_object for insmntque failure. * Need to clear v_object for insmntque failure.
*/ */
static void static void
tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg) tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg)
{ {
▲ Show 20 Lines • Show All 1,397 Lines • Show Last 20 Lines
View Options

head/sys/dev/hyperv/vmbus/hv_channel.c

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines object = vm_object_allocate_dyn(tmpfs_pager_type, size,
OBJ_COLORED | OBJ_SWAP); OBJ_COLORED | OBJ_SWAP);
if (!swap_pager_init_object(object, NULL, NULL, size, 0)) { if (!swap_pager_init_object(object, NULL, NULL, size, 0)) {
vm_object_deallocate(object); vm_object_deallocate(object);
object = NULL; object = NULL;
} }
return (object); return (object);
} }
/*
* Make sure tmpfs vnodes with writable mappings can be found on the lazy list.
*
* This allows for periodic mtime updates while only scanning vnodes which are
* plausibly dirty, see tmpfs_update_mtime_lazy.
*/
static void static void
tmpfs_pager_writecount_recalc(vm_object_t object, vm_offset_t old,
vm_offset_t new)
{
struct vnode *vp;
VM_OBJECT_ASSERT_WLOCKED(object);
vp = object->un_pager.swp.swp_tmpfs;
/*
* Forced unmount?
*/
if (vp == NULL) {
KASSERT((object->flags & OBJ_TMPFS_VREF) == 0,
("object %p with OBJ_TMPFS_VREF but without vnode", object));
VM_OBJECT_WUNLOCK(object);
return;
}
if (old == 0) {
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
("object without writtable mappings has a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
- ("object without writtable mappings has a reference"));
+ ("object without writable mappings has a reference"));
VNPASS(vp->v_usecount > 0, vp);
markj:
VNPASS(vp->v_usecount > 0, vp);
} else {
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
("object with writtable mappings does not have a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
- ("object with writtable mappings does not have a reference"));
+ ("object with writable mappings does not have a reference"));
}
if (old == new) {
markj:
mjgAuthorUnsubmitted
Done
Inline Actions

fixed locally

mjg: fixed locally
}
if (old == new) {
VM_OBJECT_WUNLOCK(object);
return;
}
if (new == 0) {
vm_object_clear_flag(object, OBJ_TMPFS_VREF);
VM_OBJECT_WUNLOCK(object);
vrele(vp);
} else {
if ((object->flags & OBJ_TMPFS_VREF) == 0) {
vref(vp);
vlazy(vp);
vm_object_set_flag(object, OBJ_TMPFS_VREF);
}
VM_OBJECT_WUNLOCK(object);
}
}
static void
tmpfs_pager_update_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
mjgAuthorUnsubmitted
Done
Inline Actions

I don't know if this assert is of any use, cargo culted this bit from the original swap pager.

mjg: I don't know if this assert is of any use, cargo culted this bit from the original swap pager.
kibUnsubmitted
Not Done
Inline Actions

It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'

kib: It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings += (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_release_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings -= (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp) tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
{ {
struct vnode *vp; struct vnode *vp;
/* /*
* Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type * Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type
* type, but not OBJ_TMPFS flag. In this case there is no * type, but not OBJ_TMPFS flag. In this case there is no
* v_writecount to adjust. * v_writecount to adjust.
Show All 15 Linestmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
if (vp_heldp != NULL) if (vp_heldp != NULL)
VM_OBJECT_RUNLOCK(object); VM_OBJECT_RUNLOCK(object);
} }
struct pagerops tmpfs_pager_ops = { struct pagerops tmpfs_pager_ops = {
.pgo_kvme_type = KVME_TYPE_VNODE, .pgo_kvme_type = KVME_TYPE_VNODE,
.pgo_alloc = tmpfs_pager_alloc, .pgo_alloc = tmpfs_pager_alloc,
.pgo_set_writeable_dirty = vm_object_set_writeable_dirty_, .pgo_set_writeable_dirty = vm_object_set_writeable_dirty_,
.pgo_update_writecount = tmpfs_pager_update_writecount,
.pgo_release_writecount = tmpfs_pager_release_writecount,
.pgo_mightbedirty = vm_object_mightbedirty_, .pgo_mightbedirty = vm_object_mightbedirty_,
.pgo_getvp = tmpfs_pager_getvp, .pgo_getvp = tmpfs_pager_getvp,
}; };
static int static int
tmpfs_node_ctor(void *mem, int size, void *arg, int flags) tmpfs_node_ctor(void *mem, int size, void *arg, int flags)
{ {
struct tmpfs_node *node; struct tmpfs_node *node;
▲ Show 20 Lines • Show All 496 Lines • ▼ Show 20 Linestmpfs_free_dirent(struct tmpfs_mount *tmp, struct tmpfs_dirent *de)
if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL) if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL)
free(de->ud.td_name, M_TMPFSNAME); free(de->ud.td_name, M_TMPFSNAME);
free(de, M_TMPFSDIR); free(de, M_TMPFSDIR);
} }
void void
tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj) tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj)
{ {
bool want_vrele;
ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject"); ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject");
if (vp->v_type != VREG || obj == NULL) if (vp->v_type != VREG || obj == NULL)
return; return;
VM_OBJECT_WLOCK(obj); VM_OBJECT_WLOCK(obj);
VI_LOCK(vp); VI_LOCK(vp);
/*
* May be going through forced unmount.
*/
want_vrele = false;
if ((obj->flags & OBJ_TMPFS_VREF) != 0) {
vm_object_clear_flag(obj, OBJ_TMPFS_VREF);
want_vrele = true;
}
kibUnsubmitted
Not Done
Inline Actions

There should be a blank line after the last line of the text where the multi-line comment applies.

kib: There should be a blank line after the last line of the text where the multi-line comment…
vm_object_clear_flag(obj, OBJ_TMPFS); vm_object_clear_flag(obj, OBJ_TMPFS);
obj->un_pager.swp.swp_tmpfs = NULL; obj->un_pager.swp.swp_tmpfs = NULL;
if (vp->v_writecount < 0) if (vp->v_writecount < 0)
vp->v_writecount = 0; vp->v_writecount = 0;
VI_UNLOCK(vp); VI_UNLOCK(vp);
VM_OBJECT_WUNLOCK(obj); VM_OBJECT_WUNLOCK(obj);
if (want_vrele) {
vrele(vp);
}
} }
/* /*
* Need to clear v_object for insmntque failure. * Need to clear v_object for insmntque failure.
*/ */
static void static void
tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg) tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg)
{ {
▲ Show 20 Lines • Show All 1,397 Lines • Show Last 20 Lines
View Options

head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines object = vm_object_allocate_dyn(tmpfs_pager_type, size,
OBJ_COLORED | OBJ_SWAP); OBJ_COLORED | OBJ_SWAP);
if (!swap_pager_init_object(object, NULL, NULL, size, 0)) { if (!swap_pager_init_object(object, NULL, NULL, size, 0)) {
vm_object_deallocate(object); vm_object_deallocate(object);
object = NULL; object = NULL;
} }
return (object); return (object);
} }
/*
* Make sure tmpfs vnodes with writable mappings can be found on the lazy list.
*
* This allows for periodic mtime updates while only scanning vnodes which are
* plausibly dirty, see tmpfs_update_mtime_lazy.
*/
static void static void
tmpfs_pager_writecount_recalc(vm_object_t object, vm_offset_t old,
vm_offset_t new)
{
struct vnode *vp;
VM_OBJECT_ASSERT_WLOCKED(object);
vp = object->un_pager.swp.swp_tmpfs;
/*
* Forced unmount?
*/
if (vp == NULL) {
KASSERT((object->flags & OBJ_TMPFS_VREF) == 0,
("object %p with OBJ_TMPFS_VREF but without vnode", object));
VM_OBJECT_WUNLOCK(object);
return;
}
if (old == 0) {
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
("object without writtable mappings has a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
- ("object without writtable mappings has a reference"));
+ ("object without writable mappings has a reference"));
VNPASS(vp->v_usecount > 0, vp);
markj:
VNPASS(vp->v_usecount > 0, vp);
} else {
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
("object with writtable mappings does not have a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
- ("object with writtable mappings does not have a reference"));
+ ("object with writable mappings does not have a reference"));
}
if (old == new) {
markj:
mjgAuthorUnsubmitted
Done
Inline Actions

fixed locally

mjg: fixed locally
}
if (old == new) {
VM_OBJECT_WUNLOCK(object);
return;
}
if (new == 0) {
vm_object_clear_flag(object, OBJ_TMPFS_VREF);
VM_OBJECT_WUNLOCK(object);
vrele(vp);
} else {
if ((object->flags & OBJ_TMPFS_VREF) == 0) {
vref(vp);
vlazy(vp);
vm_object_set_flag(object, OBJ_TMPFS_VREF);
}
VM_OBJECT_WUNLOCK(object);
}
}
static void
tmpfs_pager_update_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
mjgAuthorUnsubmitted
Done
Inline Actions

I don't know if this assert is of any use, cargo culted this bit from the original swap pager.

mjg: I don't know if this assert is of any use, cargo culted this bit from the original swap pager.
kibUnsubmitted
Not Done
Inline Actions

It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'

kib: It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings += (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_release_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings -= (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp) tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
{ {
struct vnode *vp; struct vnode *vp;
/* /*
* Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type * Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type
* type, but not OBJ_TMPFS flag. In this case there is no * type, but not OBJ_TMPFS flag. In this case there is no
* v_writecount to adjust. * v_writecount to adjust.
Show All 15 Linestmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
if (vp_heldp != NULL) if (vp_heldp != NULL)
VM_OBJECT_RUNLOCK(object); VM_OBJECT_RUNLOCK(object);
} }
struct pagerops tmpfs_pager_ops = { struct pagerops tmpfs_pager_ops = {
.pgo_kvme_type = KVME_TYPE_VNODE, .pgo_kvme_type = KVME_TYPE_VNODE,
.pgo_alloc = tmpfs_pager_alloc, .pgo_alloc = tmpfs_pager_alloc,
.pgo_set_writeable_dirty = vm_object_set_writeable_dirty_, .pgo_set_writeable_dirty = vm_object_set_writeable_dirty_,
.pgo_update_writecount = tmpfs_pager_update_writecount,
.pgo_release_writecount = tmpfs_pager_release_writecount,
.pgo_mightbedirty = vm_object_mightbedirty_, .pgo_mightbedirty = vm_object_mightbedirty_,
.pgo_getvp = tmpfs_pager_getvp, .pgo_getvp = tmpfs_pager_getvp,
}; };
static int static int
tmpfs_node_ctor(void *mem, int size, void *arg, int flags) tmpfs_node_ctor(void *mem, int size, void *arg, int flags)
{ {
struct tmpfs_node *node; struct tmpfs_node *node;
▲ Show 20 Lines • Show All 496 Lines • ▼ Show 20 Linestmpfs_free_dirent(struct tmpfs_mount *tmp, struct tmpfs_dirent *de)
if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL) if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL)
free(de->ud.td_name, M_TMPFSNAME); free(de->ud.td_name, M_TMPFSNAME);
free(de, M_TMPFSDIR); free(de, M_TMPFSDIR);
} }
void void
tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj) tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj)
{ {
bool want_vrele;
ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject"); ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject");
if (vp->v_type != VREG || obj == NULL) if (vp->v_type != VREG || obj == NULL)
return; return;
VM_OBJECT_WLOCK(obj); VM_OBJECT_WLOCK(obj);
VI_LOCK(vp); VI_LOCK(vp);
/*
* May be going through forced unmount.
*/
want_vrele = false;
if ((obj->flags & OBJ_TMPFS_VREF) != 0) {
vm_object_clear_flag(obj, OBJ_TMPFS_VREF);
want_vrele = true;
}
kibUnsubmitted
Not Done
Inline Actions

There should be a blank line after the last line of the text where the multi-line comment applies.

kib: There should be a blank line after the last line of the text where the multi-line comment…
vm_object_clear_flag(obj, OBJ_TMPFS); vm_object_clear_flag(obj, OBJ_TMPFS);
obj->un_pager.swp.swp_tmpfs = NULL; obj->un_pager.swp.swp_tmpfs = NULL;
if (vp->v_writecount < 0) if (vp->v_writecount < 0)
vp->v_writecount = 0; vp->v_writecount = 0;
VI_UNLOCK(vp); VI_UNLOCK(vp);
VM_OBJECT_WUNLOCK(obj); VM_OBJECT_WUNLOCK(obj);
if (want_vrele) {
vrele(vp);
}
} }
/* /*
* Need to clear v_object for insmntque failure. * Need to clear v_object for insmntque failure.
*/ */
static void static void
tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg) tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg)
{ {
▲ Show 20 Lines • Show All 1,397 Lines • Show Last 20 Lines