Differential D58558

libc: Reject static ELF exectables with PT_TLS segments were filesz > memsz
ClosedPublic
Actions

Authored by jhb on Thu, Jul 30, 6:19 PM.

Tags

None

Referenced Files

	F165343941: D58558.diff
	Fri, Aug 7, 6:14 PM

	Unknown Object (File)
	Wed, Aug 5, 10:20 PM

	Unknown Object (File)
	Wed, Aug 5, 1:30 PM

	Unknown Object (File)
	Wed, Aug 5, 7:57 AM

	Unknown Object (File)
	Wed, Aug 5, 5:48 AM

	Unknown Object (File)
	Tue, Aug 4, 9:44 PM

	Unknown Object (File)
	Tue, Aug 4, 5:57 PM

	Unknown Object (File)
	Mon, Aug 3, 11:00 PM

View All 18 Files

Subscribers

Details

Reviewers

Commits

rGb9eaf9b7cef2: libc: Reject static ELF exectables with PT_TLS segments were filesz > memsz

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75316
Build 72199: arc lint + arc unit

Event Timeline

jhb created this revision.Thu, Jul 30, 6:19 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Jul 30, 6:19 PM

jhb requested review of this revision.Thu, Jul 30, 6:19 PM

Harbormaster completed remote builds in B75297: Diff 183125.Thu, Jul 30, 6:19 PM

jrtc27 added inline comments.Thu, Jul 30, 9:59 PM

lib/libc/gen/tls.c
439	Any reason this is different to the rtld message ("invalid PT_TLS segment", with no full stop)? Obviously the lack of printf means we can't shove argv[0] at the start, but the rest should probably be the same?

But LGTM aside from that

This revision is now accepted and ready to land.Thu, Jul 30, 10:01 PM

jhb added inline comments.Fri, Jul 31, 2:52 PM

lib/libc/gen/tls.c
439	Oh, I can switch to "invalid". The full stop is to match all the other tls_msg() invocations in this file that all use a full stop. Whereas rtld consistently does _not_ use full stops in its _rtld_error() calls.

Switch to invalid

This revision now requires review to proceed.Fri, Jul 31, 2:53 PM

Harbormaster completed remote builds in B75316: Diff 183160.Fri, Jul 31, 2:53 PM

jrtc27 accepted this revision.Fri, Jul 31, 3:11 PM

jrtc27 added inline comments.

lib/libc/gen/tls.c
439	Oh dear, fair enough.

This revision is now accepted and ready to land.Fri, Jul 31, 3:11 PM

Closed by commit rGb9eaf9b7cef2: libc: Reject static ELF exectables with PT_TLS segments were filesz > memsz (authored by jhb). · Explain WhyFri, Jul 31, 5:58 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGb9eaf9b7cef2: libc: Reject static ELF exectables with PT_TLS segments were filesz > memsz.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

4 lines

Diff 183160

lib/libc/gen/tls.c

Loading...