Page MenuHomeFreeBSD
Differential D7191

hyperv/vmbus: Function renaming.
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Jul 12 2016, 1:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 6, 7:39 AM
Unknown Object (File)
Feb 20 2025, 10:28 AM
Unknown Object (File)
Jan 17 2025, 6:22 PM
Unknown Object (File)
Nov 7 2024, 1:47 AM
Unknown Object (File)
Oct 31 2024, 11:58 AM
Unknown Object (File)
Oct 3 2024, 10:01 PM
Unknown Object (File)
Oct 3 2024, 1:08 PM
Unknown Object (File)
Oct 3 2024, 12:25 PM
View All 59 Files
Subscribers
None

Details

Reviewers
howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger
Commits
rS302882: hyperv/vmbus: Function rename
Summary

And reorder the error prone parameters.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sepherosa_gmail.com updated this revision to Diff 18297.Jul 12 2016, 1:38 AM
sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Function renaming..
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sepherosa_gmail.com added reviewers: delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
Closed by commit rS302882: hyperv/vmbus: Function rename (authored by sephe). · Explain WhyJul 15 2016, 7:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
include/
8 lines
2 lines
netvsc/
51 lines
6 lines
storvsc/
70 lines
utilities/
4 lines
8 lines
5 lines
5 lines
vmbus/
4 lines

Diff 18297

View Options

sys/dev/hyperv/include/hyperv.h

Show First 20 Lines • Show All 1,305 Lines • ▼ Show 20 Lines for (;;) {
} }
DELAY(1); DELAY(1);
} }
} }
static int static int
its_cmd_send(struct gic_v3_its_softc *sc, struct its_cmd_desc *desc) its_cmd_send(struct gic_v3_its_softc *sc, struct its_cmd_desc *desc)
{ {
struct its_cmd *cmd, *cmd_sync; struct its_cmd *cmd, *cmd_sync, *cmd_write;
struct its_col col_sync; struct its_col col_sync;
struct its_cmd_desc desc_sync; struct its_cmd_desc desc_sync;
uint64_t target, cwriter; uint64_t target, cwriter;
mtx_lock_spin(&sc->its_spin_mtx); mtx_lock_spin(&sc->its_spin_mtx);
cmd = its_cmd_alloc_locked(sc); cmd = its_cmd_alloc_locked(sc);
mtx_unlock_spin(&sc->its_spin_mtx);
if (cmd == NULL) { if (cmd == NULL) {
device_printf(sc->dev, "could not allocate ITS command\n"); device_printf(sc->dev, "could not allocate ITS command\n");
mtx_unlock_spin(&sc->its_spin_mtx);
return (EBUSY); return (EBUSY);
} }
target = its_cmd_prepare(cmd, desc); target = its_cmd_prepare(cmd, desc);
its_cmd_sync(sc, cmd); its_cmd_sync(sc, cmd);
if (target != ITS_TARGET_NONE) { if (target != ITS_TARGET_NONE) {
mtx_lock_spin(&sc->its_spin_mtx);
cmd_sync = its_cmd_alloc_locked(sc); cmd_sync = its_cmd_alloc_locked(sc);
mtx_unlock_spin(&sc->its_spin_mtx);
if (cmd_sync == NULL) if (cmd_sync == NULL)
goto end; goto end;
desc_sync.cmd_type = ITS_CMD_SYNC; desc_sync.cmd_type = ITS_CMD_SYNC;
col_sync.col_target = target; col_sync.col_target = target;
desc_sync.cmd_desc_sync.col = &col_sync; desc_sync.cmd_desc_sync.col = &col_sync;
its_cmd_prepare(cmd_sync, &desc_sync); its_cmd_prepare(cmd_sync, &desc_sync);
its_cmd_sync(sc, cmd_sync); its_cmd_sync(sc, cmd_sync);
} }
end: end:
/* Update GITS_CWRITER */ /* Update GITS_CWRITER */
mtx_lock_spin(&sc->its_spin_mtx);
cwriter = its_cmd_cwriter_offset(sc, sc->its_cmdq_write); cwriter = its_cmd_cwriter_offset(sc, sc->its_cmdq_write);
gic_its_write(sc, 8, GITS_CWRITER, cwriter); gic_its_write(sc, 8, GITS_CWRITER, cwriter);
cmd_write = sc->its_cmdq_write;
mtx_unlock_spin(&sc->its_spin_mtx); mtx_unlock_spin(&sc->its_spin_mtx);
its_cmd_wait_completion(sc, cmd, sc->its_cmdq_write); its_cmd_wait_completion(sc, cmd, cmd_write);
return (0); return (0);
} }
static struct its_dev * static struct its_dev *
its_device_find_locked(struct gic_v3_its_softc *sc, device_t pci_dev) its_device_find_locked(struct gic_v3_its_softc *sc, device_t pci_dev)
{ {
struct its_dev *its_dev; struct its_dev *its_dev;
▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines
View Options

sys/dev/hyperv/include/vmbus.h

Show First 20 Lines • Show All 1,305 Lines • ▼ Show 20 Lines for (;;) {
} }
DELAY(1); DELAY(1);
} }
} }
static int static int
its_cmd_send(struct gic_v3_its_softc *sc, struct its_cmd_desc *desc) its_cmd_send(struct gic_v3_its_softc *sc, struct its_cmd_desc *desc)
{ {
struct its_cmd *cmd, *cmd_sync; struct its_cmd *cmd, *cmd_sync, *cmd_write;
struct its_col col_sync; struct its_col col_sync;
struct its_cmd_desc desc_sync; struct its_cmd_desc desc_sync;
uint64_t target, cwriter; uint64_t target, cwriter;
mtx_lock_spin(&sc->its_spin_mtx); mtx_lock_spin(&sc->its_spin_mtx);
cmd = its_cmd_alloc_locked(sc); cmd = its_cmd_alloc_locked(sc);
mtx_unlock_spin(&sc->its_spin_mtx);
if (cmd == NULL) { if (cmd == NULL) {
device_printf(sc->dev, "could not allocate ITS command\n"); device_printf(sc->dev, "could not allocate ITS command\n");
mtx_unlock_spin(&sc->its_spin_mtx);
return (EBUSY); return (EBUSY);
} }
target = its_cmd_prepare(cmd, desc); target = its_cmd_prepare(cmd, desc);
its_cmd_sync(sc, cmd); its_cmd_sync(sc, cmd);
if (target != ITS_TARGET_NONE) { if (target != ITS_TARGET_NONE) {
mtx_lock_spin(&sc->its_spin_mtx);
cmd_sync = its_cmd_alloc_locked(sc); cmd_sync = its_cmd_alloc_locked(sc);
mtx_unlock_spin(&sc->its_spin_mtx);
if (cmd_sync == NULL) if (cmd_sync == NULL)
goto end; goto end;
desc_sync.cmd_type = ITS_CMD_SYNC; desc_sync.cmd_type = ITS_CMD_SYNC;
col_sync.col_target = target; col_sync.col_target = target;
desc_sync.cmd_desc_sync.col = &col_sync; desc_sync.cmd_desc_sync.col = &col_sync;
its_cmd_prepare(cmd_sync, &desc_sync); its_cmd_prepare(cmd_sync, &desc_sync);
its_cmd_sync(sc, cmd_sync); its_cmd_sync(sc, cmd_sync);
} }
end: end:
/* Update GITS_CWRITER */ /* Update GITS_CWRITER */
mtx_lock_spin(&sc->its_spin_mtx);
cwriter = its_cmd_cwriter_offset(sc, sc->its_cmdq_write); cwriter = its_cmd_cwriter_offset(sc, sc->its_cmdq_write);
gic_its_write(sc, 8, GITS_CWRITER, cwriter); gic_its_write(sc, 8, GITS_CWRITER, cwriter);
cmd_write = sc->its_cmdq_write;
mtx_unlock_spin(&sc->its_spin_mtx); mtx_unlock_spin(&sc->its_spin_mtx);
its_cmd_wait_completion(sc, cmd, sc->its_cmdq_write); its_cmd_wait_completion(sc, cmd, cmd_write);
return (0); return (0);
} }
static struct its_dev * static struct its_dev *
its_device_find_locked(struct gic_v3_its_softc *sc, device_t pci_dev) its_device_find_locked(struct gic_v3_its_softc *sc, device_t pci_dev)
{ {
struct its_dev *its_dev; struct its_dev *its_dev;
▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines
View Options

sys/dev/hyperv/netvsc/hv_net_vsc.c

Show First 20 Lines • Show All 1,305 Lines • ▼ Show 20 Lines for (;;) {
} }
DELAY(1); DELAY(1);
} }
} }
static int static int
its_cmd_send(struct gic_v3_its_softc *sc, struct its_cmd_desc *desc) its_cmd_send(struct gic_v3_its_softc *sc, struct its_cmd_desc *desc)
{ {
struct its_cmd *cmd, *cmd_sync; struct its_cmd *cmd, *cmd_sync, *cmd_write;
struct its_col col_sync; struct its_col col_sync;
struct its_cmd_desc desc_sync; struct its_cmd_desc desc_sync;
uint64_t target, cwriter; uint64_t target, cwriter;
mtx_lock_spin(&sc->its_spin_mtx); mtx_lock_spin(&sc->its_spin_mtx);
cmd = its_cmd_alloc_locked(sc); cmd = its_cmd_alloc_locked(sc);
mtx_unlock_spin(&sc->its_spin_mtx);
if (cmd == NULL) { if (cmd == NULL) {
device_printf(sc->dev, "could not allocate ITS command\n"); device_printf(sc->dev, "could not allocate ITS command\n");
mtx_unlock_spin(&sc->its_spin_mtx);
return (EBUSY); return (EBUSY);
} }
target = its_cmd_prepare(cmd, desc); target = its_cmd_prepare(cmd, desc);
its_cmd_sync(sc, cmd); its_cmd_sync(sc, cmd);
if (target != ITS_TARGET_NONE) { if (target != ITS_TARGET_NONE) {
mtx_lock_spin(&sc->its_spin_mtx);
cmd_sync = its_cmd_alloc_locked(sc); cmd_sync = its_cmd_alloc_locked(sc);
mtx_unlock_spin(&sc->its_spin_mtx);
if (cmd_sync == NULL) if (cmd_sync == NULL)
goto end; goto end;
desc_sync.cmd_type = ITS_CMD_SYNC; desc_sync.cmd_type = ITS_CMD_SYNC;
col_sync.col_target = target; col_sync.col_target = target;
desc_sync.cmd_desc_sync.col = &col_sync; desc_sync.cmd_desc_sync.col = &col_sync;
its_cmd_prepare(cmd_sync, &desc_sync); its_cmd_prepare(cmd_sync, &desc_sync);
its_cmd_sync(sc, cmd_sync); its_cmd_sync(sc, cmd_sync);
} }
end: end:
/* Update GITS_CWRITER */ /* Update GITS_CWRITER */
mtx_lock_spin(&sc->its_spin_mtx);
cwriter = its_cmd_cwriter_offset(sc, sc->its_cmdq_write); cwriter = its_cmd_cwriter_offset(sc, sc->its_cmdq_write);
gic_its_write(sc, 8, GITS_CWRITER, cwriter); gic_its_write(sc, 8, GITS_CWRITER, cwriter);
cmd_write = sc->its_cmdq_write;
mtx_unlock_spin(&sc->its_spin_mtx); mtx_unlock_spin(&sc->its_spin_mtx);
its_cmd_wait_completion(sc, cmd, sc->its_cmdq_write); its_cmd_wait_completion(sc, cmd, cmd_write);
return (0); return (0);
} }
static struct its_dev * static struct its_dev *
its_device_find_locked(struct gic_v3_its_softc *sc, device_t pci_dev) its_device_find_locked(struct gic_v3_its_softc *sc, device_t pci_dev)
{ {
struct its_dev *its_dev; struct its_dev *its_dev;
▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines
View Options

sys/dev/hyperv/netvsc/hv_rndis_filter.c

Show First 20 Lines • Show All 1,305 Lines • ▼ Show 20 Lines for (;;) {
} }
DELAY(1); DELAY(1);
} }
} }
static int static int
its_cmd_send(struct gic_v3_its_softc *sc, struct its_cmd_desc *desc) its_cmd_send(struct gic_v3_its_softc *sc, struct its_cmd_desc *desc)
{ {
struct its_cmd *cmd, *cmd_sync; struct its_cmd *cmd, *cmd_sync, *cmd_write;
struct its_col col_sync; struct its_col col_sync;
struct its_cmd_desc desc_sync; struct its_cmd_desc desc_sync;
uint64_t target, cwriter; uint64_t target, cwriter;
mtx_lock_spin(&sc->its_spin_mtx); mtx_lock_spin(&sc->its_spin_mtx);
cmd = its_cmd_alloc_locked(sc); cmd = its_cmd_alloc_locked(sc);
mtx_unlock_spin(&sc->its_spin_mtx);
if (cmd == NULL) { if (cmd == NULL) {
device_printf(sc->dev, "could not allocate ITS command\n"); device_printf(sc->dev, "could not allocate ITS command\n");
mtx_unlock_spin(&sc->its_spin_mtx);
return (EBUSY); return (EBUSY);
} }
target = its_cmd_prepare(cmd, desc); target = its_cmd_prepare(cmd, desc);
its_cmd_sync(sc, cmd); its_cmd_sync(sc, cmd);
if (target != ITS_TARGET_NONE) { if (target != ITS_TARGET_NONE) {
mtx_lock_spin(&sc->its_spin_mtx);
cmd_sync = its_cmd_alloc_locked(sc); cmd_sync = its_cmd_alloc_locked(sc);
mtx_unlock_spin(&sc->its_spin_mtx);
if (cmd_sync == NULL) if (cmd_sync == NULL)
goto end; goto end;
desc_sync.cmd_type = ITS_CMD_SYNC; desc_sync.cmd_type = ITS_CMD_SYNC;
col_sync.col_target = target; col_sync.col_target = target;
desc_sync.cmd_desc_sync.col = &col_sync; desc_sync.cmd_desc_sync.col = &col_sync;
its_cmd_prepare(cmd_sync, &desc_sync); its_cmd_prepare(cmd_sync, &desc_sync);
its_cmd_sync(sc, cmd_sync); its_cmd_sync(sc, cmd_sync);
} }
end: end:
/* Update GITS_CWRITER */ /* Update GITS_CWRITER */
mtx_lock_spin(&sc->its_spin_mtx);
cwriter = its_cmd_cwriter_offset(sc, sc->its_cmdq_write); cwriter = its_cmd_cwriter_offset(sc, sc->its_cmdq_write);
gic_its_write(sc, 8, GITS_CWRITER, cwriter); gic_its_write(sc, 8, GITS_CWRITER, cwriter);
cmd_write = sc->its_cmdq_write;
mtx_unlock_spin(&sc->its_spin_mtx); mtx_unlock_spin(&sc->its_spin_mtx);
its_cmd_wait_completion(sc, cmd, sc->its_cmdq_write); its_cmd_wait_completion(sc, cmd, cmd_write);
return (0); return (0);
} }
static struct its_dev * static struct its_dev *
its_device_find_locked(struct gic_v3_its_softc *sc, device_t pci_dev) its_device_find_locked(struct gic_v3_its_softc *sc, device_t pci_dev)
{ {
struct its_dev *its_dev; struct its_dev *its_dev;
▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines
View Options

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c

Loading...
View Options

sys/dev/hyperv/utilities/hv_heartbeat.c

Loading...
View Options

sys/dev/hyperv/utilities/hv_kvp.c

Loading...
View Options

sys/dev/hyperv/utilities/hv_shutdown.c

Loading...
View Options

sys/dev/hyperv/utilities/hv_timesync.c

Loading...
View Options

sys/dev/hyperv/vmbus/hv_channel.c

Loading...