ssh-sk-helper if MK_USB == no
ClosedPublic
Actions

Authored by ngie on Wed, Jul 15, 12:39 AM.

Details

Reviewers

Commits

rG4db3872aabc3: Only build secure/libexec/ssh-sk-helper if MK_USB == no

Summary

The ssh-sk-helper utility only functions if/when MK_USB == yes.
Installing it on systems where MK_USB == no doesn't make sense.

Test Plan

This change unbreaks the build with a VM where MK_USB == no is set.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74819
Build 71702: arc lint + arc unit

Event Timeline

ngie created this revision.Wed, Jul 15, 12:39 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Jul 15, 12:39 AM

ngie requested review of this revision.Wed, Jul 15, 12:39 AM

Harbormaster completed remote builds in B74819: Diff 182014.Wed, Jul 15, 12:39 AM

Remove redundant SRCS entry added in original diff.
Add MK_USB == no entries to OptionalObsoleteFiles.inc .

Harbormaster completed remote builds in B74820: Diff 182015.Wed, Jul 15, 12:46 AM

ngie edited the summary of this revision. (Show Details)Wed, Jul 15, 12:47 AM

ngie edited the test plan for this revision. (Show Details)

ngie added a reviewer: emaste.

ngie added a subscriber: des.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jul 22, 7:34 PM

Closed by commit rG4db3872aabc3: Only build secure/libexec/ssh-sk-helper if MK_USB == no (authored by ngie). · Explain Why

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG4db3872aabc3: Only build secure/libexec/ssh-sk-helper if MK_USB == no.

Revision Contents
Changeset List

Path

Size

secure/

libexec/

Makefile

4 lines

ssh-sk-helper/

Makefile

6 lines

Diff 182014

View Options

secure/libexec/Makefile