Page MenuHomeFreeBSD

rockchip: fix stack overflow in rk8xx_rtc
ClosedPublic

Authored by kevans on Sun, Jul 12, 1:17 AM.
Tags
None
Referenced Files
F164371885: D58182.diff
Fri, Jul 31, 6:32 AM
Unknown Object (File)
Wed, Jul 29, 3:14 PM
Unknown Object (File)
Tue, Jul 28, 8:52 AM
Unknown Object (File)
Tue, Jul 28, 4:30 AM
Unknown Object (File)
Tue, Jul 28, 12:07 AM
Unknown Object (File)
Mon, Jul 27, 4:38 AM
Unknown Object (File)
Thu, Jul 23, 2:30 PM
Unknown Object (File)
Thu, Jul 23, 9:22 AM
Subscribers

Details

Summary

Presumably surfaced by -fstack-protector-strong, rk8xx_settime was
triggering SSP when ntpd set the time on the RockPro64, at the very
least. A minor oops meant that the weeks mask was getting tossed into
the wrong field, and the mask was never populated. The mask is 0x7 for
all three of these, thus overflowing the data array in settime by one
byte.

Reported by: jsm, "Tenkawa" on Discord

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 74731
Build 71614: arc lint + arc unit