Differential D58100

fwcam: defer ISO streaming to first read
ClosedPublic
Actions

Authored by guest-seuros on Wed, Jul 8, 8:08 AM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, Jul 16, 11:31 AM

	Unknown Object (File)
	Thu, Jul 16, 10:51 AM

	Unknown Object (File)
	Thu, Jul 16, 3:43 AM

	Unknown Object (File)
	Thu, Jul 16, 1:57 AM

	Unknown Object (File)
	Thu, Jul 16, 1:57 AM

	Unknown Object (File)
	Wed, Jul 15, 10:51 PM

	Unknown Object (File)
	Wed, Jul 15, 11:11 AM

	Unknown Object (File)
	Wed, Jul 15, 11:08 AM

View All 23 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG56d4dee82de1: fwcam: defer ISO streaming to first read

Summary

Moved ISO start to first usage. Opening the device now
only validates state and increments the open count, allowing info
queries and mode changes without starting the camera. ISO streaming
begins on demand when userland first reads frame data.
This avoid the camera led to turn-on at attach.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 74610
Build 71493: arc lint + arc unit

Event Timeline

guest-seuros created this revision.Wed, Jul 8, 8:08 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Jul 8, 8:08 AM

guest-seuros requested review of this revision.Wed, Jul 8, 8:08 AM

Harbormaster completed remote builds in B74610: Diff 181524.Wed, Jul 8, 8:08 AM

guest-seuros added a reviewer: firewire.Wed, Jul 8, 8:26 AM

guest-seuros added projects: firewire, drivers.

adrian accepted this revision.Thu, Jul 9, 12:56 AM

This revision is now accepted and ready to land.Thu, Jul 9, 12:56 AM

adrian added a child revision: D58101: fwcam: retry ISO enable after re-powering camera.Thu, Jul 9, 12:56 AM

Closed by commit rG56d4dee82de1: fwcam: defer ISO streaming to first read (authored by guest-seuros, committed by adrian). · Explain WhyThu, Jul 9, 2:54 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG56d4dee82de1: fwcam: defer ISO streaming to first read.

Revision Contents
Changeset List

Path

Size

sys/

dev/

firewire/

24 lines

Diff 181524

sys/dev/firewire/fwcam.c

Loading...