newvers.sh: Avoid spurious -dirty in git revision
ClosedPublic
Actions

Authored by emaste on Jul 1 2026, 2:38 PM.

Details

Reviewers

gordon
jlduran
jhb

Group Reviewers

build

Commits

rG6756f09d73de: newvers.sh: Avoid spurious -dirty in git revision
rG45da2c1e1d20: newvers.sh: Avoid spurious -dirty in git revision
rG465a3b7adc00: newvers.sh: Avoid spurious -dirty in git revision

Summary

If git is installed and .git exists but git rev-parse failed to report a
hash we previously produced just "-dirty" as the git revision.  Gate the
git commit count and -dirty check on the rev-parse passing.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Jul 1 2026, 2:38 PM

emaste created this revision.

jhb might have some views here too.

This is fine by me.
So, if git-rev-parse(1) fails, we just silently ignore it? Maybe erroring in the else branch is too aggressive.

This revision is now accepted and ready to land.Jul 1 2026, 9:44 PM

Closed by commit rG465a3b7adc00: newvers.sh: Avoid spurious -dirty in git revision (authored by emaste). · Explain WhyJul 3 2026, 1:36 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG465a3b7adc00: newvers.sh: Avoid spurious -dirty in git revision.

Herald added a subscriber: imp. · View Herald TranscriptJul 3 2026, 1:36 PM

emaste added a commit: rG45da2c1e1d20: newvers.sh: Avoid spurious -dirty in git revision.Jul 9 2026, 3:19 PM

emaste added a commit: rG6756f09d73de: newvers.sh: Avoid spurious -dirty in git revision.

Revision Contents
Changeset List

Path

Size

sys/

conf/

newvers.sh

28 lines

Diff 181251

View Options

newvers.sh: Avoid spurious -dirty in git revisionClosedPublicActions