Differential D57966

evdev: use a prometheus-safe label for ev_sysctl_tree
ClosedPublic
Actions

Authored by kevans on Tue, Jun 30, 2:21 PM.

Tags

None

Referenced Files

	F164188794: D57966.diff
	Wed, Jul 29, 11:25 AM

	F164175601: D57966.diff
	Wed, Jul 29, 9:05 AM

	Unknown Object (File)
	Sat, Jul 25, 6:54 PM

	Unknown Object (File)
	Tue, Jul 21, 12:04 AM

	Unknown Object (File)
	Thu, Jul 16, 3:20 AM

	Unknown Object (File)
	Thu, Jul 16, 1:29 AM

	Unknown Object (File)
	Wed, Jul 15, 7:28 AM

	Unknown Object (File)
	Wed, Jul 15, 7:28 AM

Subscribers

Details

Reviewers

wulf
asomers

Commits

rGcb8bda40695f: evdev: use a prometheus-safe label for ev_sysctl_tree

Summary

Prometheus doesn't allow spaces, let's normalize this to what we use
elsewhere for consistency. The sysctl exporter could probably do this
itself, but let's decouple that from the immediate problem: matching the
label between the exported data and in-tree is nice for greppability.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 74415
Build 71298: arc lint + arc unit

Event Timeline

kevans created this revision.Tue, Jun 30, 2:21 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Jun 30, 2:21 PM

kevans requested review of this revision.Tue, Jun 30, 2:21 PM

Harbormaster completed remote builds in B74415: Diff 180986.Tue, Jun 30, 2:21 PM

asomers accepted this revision.Tue, Jun 30, 2:51 PM

This revision is now accepted and ready to land.Tue, Jun 30, 2:51 PM

wulf accepted this revision.Tue, Jun 30, 3:24 PM

Closed by commit rGcb8bda40695f: evdev: use a prometheus-safe label for ev_sysctl_tree (authored by kevans). · Explain WhyTue, Jun 30, 4:52 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rGcb8bda40695f: evdev: use a prometheus-safe label for ev_sysctl_tree.

Revision Contents
Changeset List

Path

Size

sys/

dev/

evdev/

2 lines

Diff 180986

sys/dev/evdev/evdev.c

Loading...