Page MenuHomeFreeBSD
Differential D57821

stand: Fix display offset
ClosedPublic
Actions

Authored by aokblast on Wed, Jun 24, 3:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 7, 5:21 AM
Unknown Object (File)
Mon, Jul 6, 1:03 PM
Unknown Object (File)
Sun, Jul 5, 10:27 PM
Unknown Object (File)
Sun, Jul 5, 10:24 PM
Unknown Object (File)
Sun, Jul 5, 7:32 PM
Unknown Object (File)
Sun, Jul 5, 5:17 PM
Unknown Object (File)
Sun, Jul 5, 5:17 PM
Unknown Object (File)
Sun, Jul 5, 5:13 PM
View All 26 Files
Subscribers
dab
imp

Details

Reviewers
manu
naito.yuichiro_gmail.com
imp
Commits
rG76aa776b5f47: stand: Fix shadow buffer offset handling

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 74204
Build 71087: arc lint + arc unit

Event Timeline

aokblast created this revision.Wed, Jun 24, 3:02 PM
Herald added a reviewer: manu. · View Herald TranscriptWed, Jun 24, 3:02 PM
Herald added subscribers: dab, imp. · View Herald Transcript
aokblast requested review of this revision.Wed, Jun 24, 3:02 PM
Harbormaster completed remote builds in B74204: Diff 180538.Wed, Jun 24, 3:02 PM
aokblast added a reviewer: naito.yuichiro_gmail.com.Wed, Jun 24, 3:07 PM
naito.yuichiro_gmail.com added a comment.Thu, Jun 25, 1:38 AM

Your patch fixes my boot loader. Thank you!
After applying the patch, my boot loader menu appears normally, as shown in the following picture.

IMG_5206.jpeg (3×5 px, 1 MB)

imp accepted this revision.Sat, Jun 27, 9:26 PM

A more verbose commit message would be nice :)
But the changes look OK to me, but I'm not 100% sure what I'm looking at...
But given the visuals, this is the sort of change I'd expect.

This revision is now accepted and ready to land.Sat, Jun 27, 9:26 PM
Closed by commit rG76aa776b5f47: stand: Fix shadow buffer offset handling (authored by aokblast). · Explain WhyTue, Jun 30, 7:53 PM
This revision was automatically updated to reflect the committed changes.
aokblast added a commit: rG76aa776b5f47: stand: Fix shadow buffer offset handling.

Revision Contents
Changeset List

PathSize
stand/
common/
39 lines

Diff 180538

View Options

stand/common/gfx_fb.c

Loading...