Page MenuHomeFreeBSD

bsnmpd/snmp_hostres: fix hrFSTable remoteMountPoint leak
ClosedPublic

Authored by oshogbo on Tue, Jun 16, 11:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 3, 1:10 PM
Unknown Object (File)
Fri, Jul 3, 5:25 AM
Unknown Object (File)
Fri, Jul 3, 5:18 AM
Unknown Object (File)
Thu, Jul 2, 5:34 AM
Unknown Object (File)
Thu, Jul 2, 5:27 AM
Unknown Object (File)
Thu, Jul 2, 4:11 AM
Unknown Object (File)
Thu, Jul 2, 4:07 AM
Unknown Object (File)
Tue, Jun 30, 3:44 PM
Subscribers

Details

Summary

Free the previous value before re-strdup'ing, and initialise
remoteMountPoint to NULL in fs_entry_create() so the free() is safe on
the newly-created path

Observed via a dtrace leak snapshot on 15.0-RELEASE-p4:

data leaked = 1983, count = 1683

libc.so.7`malloc+0xa8
snmp_hostres.so.6`fs_tbl_process_statfs_entry+0x276
snmp_hostres.so.6`refresh_storage_tbl+0x502
snmp_hostres.so.6`op_hrStorageTable+0x1a
libbsnmp.so.7`0x2a2b1892ba3d
libbsnmp.so.7`snmp_getbulk+0x37f

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable