ppp: Don't fetch a non-existent variadic argument
ClosedPublic
Actions

Authored by jhb on May 20 2026, 7:31 PM.

Details

Reviewers

brooks
jrtc27

Group Reviewers

cheri

Commits

rGd143c08f88ca: ppp: Don't fetch a non-existent variadic argument
rGcf5b5966f52c: ppp: Don't fetch a non-existent variadic argument
rGb5a8b933d499: ppp: Don't fetch a non-existent variadic argument

Summary

Only fetch the optional mode argument to ID0open to pass to open(2) if
O_CREAT is present in the flags argument. It is UB to fetch an
argument that doesn't exist. On CHERI this UB results in a fault.

Obtained from: CheriBSD
Sponsored by: AFRL, DARPA

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.May 20 2026, 7:31 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 20 2026, 7:31 PM

jhb requested review of this revision.May 20 2026, 7:31 PM

Herald added a reviewer: cheri. · View Herald TranscriptMay 20 2026, 7:31 PM

Harbormaster completed remote builds in B73293: Diff 178223.May 20 2026, 7:31 PM

brooks accepted this revision.May 27 2026, 7:48 AM

This revision is now accepted and ready to land.May 27 2026, 7:48 AM

Closed by commit rGb5a8b933d499: ppp: Don't fetch a non-existent variadic argument (authored by jhb). · Explain WhyJun 10 2026, 1:52 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGb5a8b933d499: ppp: Don't fetch a non-existent variadic argument.

jhb added a commit: rGcf5b5966f52c: ppp: Don't fetch a non-existent variadic argument.Thu, Oct 8, 8:44 PM

jhb added a commit: rGd143c08f88ca: ppp: Don't fetch a non-existent variadic argument.Fri, Oct 9, 12:20 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ppp/

id.c

5 lines

Diff 179567

View Options

ppp: Don't fetch a non-existent variadic argumentClosedPublicActions