zonectl: display conventional zones better during RZ
ClosedPublic
Actions

Authored by asomers on Jun 9 2026, 6:09 PM.

Details

Reviewers

ken
fuz

Commits

rG4735ef6196bc: zonectl: display conventional zones better during RZ

Summary

zonectl's Report Zones subcommand displays a tabular list of zones. A
conventional zone's WP column is displayed as 0xffffffffffffffff , the
literal value that the HDD reports. But that's too wide for the column,
causing the text to be misaligned. It's also not really meaningful,
because the Write Pointer isn't really defined for a Conventional zone. Change it to "N/A" to fix the text misalignment.

MFC after: 2 weeks
Sponsored by: ConnectWise

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 73772
Build 70655: arc lint + arc unit

Event Timeline

asomers created this revision.Jun 9 2026, 6:09 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 9 2026, 6:09 PM

asomers requested review of this revision.Jun 9 2026, 6:09 PM

Harbormaster completed remote builds in B73772: Diff 179471.Jun 9 2026, 6:10 PM

Before:

55880 zones, Maximum LBA 0xda47ffff (3662151679)
Zone lengths are the same, types vary
  Start LBA  Length       WP LBA      Zone Type      Condition      Sequential             Reset
          0,  65536, 0xffffffffffffffff,  Conventional,           NWP,     Sequential,  No Reset Needed
    0x10000,  65536, 0xffffffffffffffff,  Conventional,           NWP,     Sequential,  No Reset Needed

After:

55880 zones, Maximum LBA 0xda47ffff (3662151679)
Zone lengths are the same, types vary
  Start LBA  Length       WP LBA      Zone Type      Condition      Sequential             Reset
          0,  65536,         N/A,  Conventional,           NWP,     Sequential,  No Reset Needed
    0x10000,  65536,         N/A,  Conventional,           NWP,     Sequential,  No Reset Needed

Can we change it to say -1 so it still parses as a number? n/a looks like something scripts will dislike.

In D57512#1318003, @fuz wrote:

Can we change it to say -1 so it still parses as a number? n/a looks like something scripts will dislike.

Yes we can. In fact, I tried that first, but switched to "N/A" because I thought that -1 might look like a mistake. @ken what do you think?

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Jul 11, 8:32 PM

Closed by commit rG4735ef6196bc: zonectl: display conventional zones better during RZ (authored by asomers). · Explain Why

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rG4735ef6196bc: zonectl: display conventional zones better during RZ.

Revision Contents
Changeset List

Path

Size

usr.sbin/

zonectl/

zonectl.c

11 lines

Diff 179471

View Options

usr.sbin/zonectl/zonectl.c

zonectl: display conventional zones better during RZClosedPublicActions