audit: Replace TAILQ with STAILQ
ClosedPublic
Actions

Authored by des on Jun 5 2026, 7:35 AM.

Details

Reviewers

kevans
csjp
emaste

Commits

rGbc5f0ff387d8: audit: Replace TAILQ with STAILQ
rG9b30dccaefea: audit: Replace TAILQ with STAILQ
rG77e894cb09af: audit: Replace TAILQ with STAILQ

Summary

This reduces the size of a trigger entry from 24 bytes to 16 (or from
12 bytes to 8 on 32-bit) with no additional complexity.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73698
Build 70581: arc lint + arc unit

Event Timeline

des created this revision.Jun 5 2026, 7:35 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 5 2026, 7:35 AM

des requested review of this revision.Jun 5 2026, 7:35 AM

Harbormaster completed remote builds in B73698: Diff 179262.Jun 5 2026, 7:35 AM

des edited the summary of this revision. (Show Details)Jun 5 2026, 7:37 AM

So it was a TAILQ but we only used the fwd direction?

emaste accepted this revision.Jun 5 2026, 3:09 PM

This revision is now accepted and ready to land.Jun 5 2026, 3:09 PM

kevans accepted this revision.Jun 5 2026, 3:18 PM

In D57464#1316510, @emaste wrote:

So it was a TAILQ but we only used the fwd direction?

Yep, all we ever do is append at the tail and pull at the head.

Closed by commit rG77e894cb09af: audit: Replace TAILQ with STAILQ (authored by des). · Explain WhyJun 5 2026, 9:51 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG77e894cb09af: audit: Replace TAILQ with STAILQ.

des added a commit: rG9b30dccaefea: audit: Replace TAILQ with STAILQ.Tue, Jun 16, 1:01 AM

des added a commit: rGbc5f0ff387d8: audit: Replace TAILQ with STAILQ.

Revision Contents
Changeset List

Path

Size

sys/

security/

audit/

audit_trigger.c

22 lines

Diff 179262

View Options

sys/security/audit/audit_trigger.c

audit: Replace TAILQ with STAILQClosedPublicActions