Sponsored by: SkunkWerks, GmbH
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 73512 Build 70395: arc lint + arc unit
Event Timeline
Comment Actions
Apart from the following stage-qa warning this looks great
Error: /usr/local/bin/gitte is linked to /usr/local/lib/libcairo.so.2 from graphics/cairo but it is not declared as a dependency Warning: you need USE_GNOME+=cairo Error: /usr/local/bin/gitte is linked to /usr/local/lib/libgraphene-1.0.so.0 from graphics/graphene but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libgraphene-1.0.so:graphics/graphene
Comment Actions
It seems that desktop-file-validate and appstreamcli utils are only invoked as a part of make test.
Consider adding OPTIONS_DEFINE= TEST and moving these deps to TEST_BUILD_DEPENDS.
| deskutils/gitte/Makefile | ||
|---|---|---|
| 30 | Style nitpick: either move TEST_DESC closer to TEST_BUILD_DEPENDS or just remove this empty line altogether. | |