deskutils/gitte: new port Gitte, a GNOME git desktop client
ClosedPublic
Actions

Authored by dch on Thu, May 28, 11:26 AM.

Details

Reviewers

arrowd

Commits

R11:d6a455a3a41b: deskutils/gitte: new port Gitte, a GNOME git desktop client

Summary

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73502
Build 70385: arc lint + arc unit

Event Timeline

dch requested review of this revision.Thu, May 28, 11:26 AM

dch created this revision.

Harbormaster completed remote builds in B73501: Diff 178805.Thu, May 28, 11:26 AM

trim pkg-descr

Harbormaster completed remote builds in B73502: Diff 178806.Thu, May 28, 11:27 AM

Apart from the following stage-qa warning this looks great

Error: /usr/local/bin/gitte is linked to /usr/local/lib/libcairo.so.2 from graphics/cairo but it is not declared as a dependency
Warning: you need USE_GNOME+=cairo
Error: /usr/local/bin/gitte is linked to /usr/local/lib/libgraphene-1.0.so.0 from graphics/graphene but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libgraphene-1.0.so:graphics/graphene

This revision is now accepted and ready to land.Thu, May 28, 12:59 PM

It seems that desktop-file-validate and appstreamcli utils are only invoked as a part of make test.
Consider adding OPTIONS_DEFINE= TEST and moving these deps to TEST_BUILD_DEPENDS.