nanobsd: Adjust the order of the flags in makefs
ClosedPublic
Actions

Authored by jlduran on May 24 2026, 11:01 AM.

Details

Reviewers

imp
senguptaangshuman17_gmail.com

Commits

rG54359982309e: nanobsd: Adjust the order of the flags in makefs

Summary

The order of the flags matter in makefs(8). The -t (type) flag must come
before the -o (options), otherwise the options are reset.

Move the -t flag before the -o flag and remove the shim function
_xxx_adjust_code_size() that was created to align to the default makefs
FFS values.

It effectively prevented us from generating NanoBSD images using
unprivileged builds with the partitions internally aligned as intended.

Test Plan

sh nanobsd.sh -U

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jlduran created this revision.May 24 2026, 11:01 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 24 2026, 11:01 AM

jlduran requested review of this revision.May 24 2026, 11:01 AM

Harbormaster completed remote builds in B73409: Diff 178523.May 24 2026, 11:01 AM

jlduran added a parent revision: D57225: nanobsd: Use makefs -R flag to honor rounded sizes.May 24 2026, 11:01 AM

jlduran edited the test plan for this revision. (Show Details)May 24 2026, 6:45 PM

jlduran added reviewers: imp, senguptaangshuman17_gmail.com.

Finally I was able to "unveil" the mystery of makefs' partition alignment. This was the actual issue: the -t ffs option should appear before the -o option. In my brief testing, I was finally able to produce an image that is partitioned exactly as the root-built one, doing it as an unprivileged user. While at it, I also fixed a number of other tangentially-related issues regarding non-privileged builds on NanoBSD (the rest of the stack). As well as preparing the ground for some changes that are yet to come as part of the GSoC project.

imp accepted this revision.May 24 2026, 6:58 PM

This revision is now accepted and ready to land.May 24 2026, 6:58 PM

Nice catch

senguptaangshuman17_gmail.com accepted this revision.May 26 2026, 7:12 AM

Closed by commit rG54359982309e: nanobsd: Adjust the order of the flags in makefs (authored by jlduran). · Explain WhyMay 27 2026, 12:37 AM

This revision was automatically updated to reflect the committed changes.

jlduran added a commit: rG54359982309e: nanobsd: Adjust the order of the flags in makefs.