nanobsd: Fix code image size formatting
ClosedPublic
Actions

Authored by jlduran on May 24 2026, 11:01 AM.

Tags

None

Referenced Files

	F162924466: D57224.id.diff
	Sat, Jul 18, 8:45 AM

	Unknown Object (File)
	Thu, Jul 16, 10:20 AM

	Unknown Object (File)
	Wed, Jul 15, 7:23 AM

	Unknown Object (File)
	Wed, Jul 15, 7:23 AM

	Unknown Object (File)
	Jun 6 2026, 4:13 PM

	Unknown Object (File)
	Jun 6 2026, 4:09 PM

	Unknown Object (File)
	Jun 5 2026, 1:30 PM

	Unknown Object (File)
	Jun 5 2026, 1:26 PM

View All 25 Files

Subscribers

imp

Details

Reviewers

imp

Commits

rGca2d4026c3f2: nanobsd: Fix code image size formatting

Summary

mkimg(8) parses sizes using expand_number(3). It is an error to use "b"
as a suffix. This is the result of a confusion with makefs(8), which
uses NetBSD's strsuftoll(3).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jlduran created this revision.May 24 2026, 11:01 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 24 2026, 11:01 AM

jlduran requested review of this revision.May 24 2026, 11:01 AM

Harbormaster completed remote builds in B73407: Diff 178521.May 24 2026, 11:01 AM

jlduran added a parent revision: D57223: nanobsd: Refactor secondary code partition logic.May 24 2026, 11:01 AM

jlduran added a child revision: D57225: nanobsd: Use makefs -R flag to honor rounded sizes.

imp accepted this revision.May 24 2026, 11:24 PM

This revision is now accepted and ready to land.May 24 2026, 11:24 PM

Closed by commit rGca2d4026c3f2: nanobsd: Fix code image size formatting (authored by jlduran). · Explain WhyMay 27 2026, 12:37 AM

This revision was automatically updated to reflect the committed changes.

jlduran added a commit: rGca2d4026c3f2: nanobsd: Fix code image size formatting.

Revision Contents
Changeset List

Path

Size

tools/

nanobsd/

legacy.sh

2 lines

Diff 178679

View Options

tools/tools/nanobsd/legacy.sh

nanobsd: Fix code image size formattingClosedPublicActions