Page MenuHomeFreeBSD
Differential D56718

fix(acpi_panasonic): acquire serial lock before calling hkey_sound_mute in shutdown
ClosedPublic
Actions

Authored by seuros on Apr 29 2026, 9:59 PM.
Tags
None
Referenced Files
F168370632: D56718.id.diff
Thu, Aug 27, 8:04 PM
Unknown Object (File)
Wed, Aug 26, 3:12 PM
Unknown Object (File)
Tue, Aug 25, 12:31 PM
Unknown Object (File)
Tue, Aug 25, 12:30 PM
Unknown Object (File)
Thu, Aug 20, 6:21 PM
Unknown Object (File)
Fri, Aug 14, 2:46 AM
Unknown Object (File)
Wed, Aug 12, 3:01 PM
Unknown Object (File)
Wed, Aug 12, 12:32 AM
View All 54 Files
Subscribers
imp

Details

Reviewers
imp
ngie
Commits
rG7619d14d08a0: acpi_panasonic: acquire serial lock before calling hkey_sound_mute in shutdown
Summary

acpi_panasonic_shutdown() calls hkey_sound_mute() without holding the ACPI serial lock.
Every other call site holds ACPI_SERIAL_BEGIN(panasonic) before calling it, as the locking model is caller-owned.

This seems to affect the whole Panasonic Toughtbook lineup btw.

Test Plan

Boot a Panasonic Notebook with acpi_panasonic loaded. Trigger a clean shutdown and reboot, verify no static audio burst through the speaker.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 72643
Build 69526: arc lint + arc unit

Event Timeline

seuros created this revision.Apr 29 2026, 9:59 PM
seuros held this revision as a draft.
Herald added a subscriber: imp. · View Herald TranscriptApr 29 2026, 9:59 PM
Harbormaster completed remote builds in B72643: Diff 176827.Apr 29 2026, 9:59 PM
seuros published this revision for review.Apr 29 2026, 10:48 PM
seuros edited the summary of this revision. (Show Details)
seuros edited the test plan for this revision. (Show Details)
seuros added a reviewer: imp.
seuros added a reviewer: ngie.Apr 30 2026, 10:50 PM
ngie accepted this revision.May 5 2026, 7:47 PM

hkey_sound_mute calls ACPI_SERIAL_ASSERT(..), which I assume is where things panic. This is a pretty straightforward change.

This revision is now accepted and ready to land.May 5 2026, 7:47 PM
Closed by commit rG7619d14d08a0: acpi_panasonic: acquire serial lock before calling hkey_sound_mute in shutdown (authored by seuros, committed by ngie). · Explain WhyMay 5 2026, 7:52 PM
This revision was automatically updated to reflect the committed changes.
ngie added a commit: rG7619d14d08a0: acpi_panasonic: acquire serial lock before calling hkey_sound_mute in shutdown.

Revision Contents
Changeset List

PathSize
sys/
dev/
acpi_support/
2 lines

Diff 176827

View Options

sys/dev/acpi_support/acpi_panasonic.c

Loading...