Page MenuHomeFreeBSD

bnxt_en: Address review comments for core SR-IOV support
ClosedPublic

Authored by chandrakanth.patil_broadcom.com on Apr 26 2026, 1:01 PM.
Tags
None
Referenced Files
F170698042: D56644.id176702.diff
Sun, Sep 6, 2:13 AM
Unknown Object (File)
Sat, Sep 5, 2:23 AM
Unknown Object (File)
Fri, Sep 4, 11:49 PM
Unknown Object (File)
Fri, Sep 4, 9:55 PM
Unknown Object (File)
Thu, Sep 3, 10:58 AM
Unknown Object (File)
Thu, Sep 3, 10:54 AM
Unknown Object (File)
Thu, Sep 3, 10:31 AM
Unknown Object (File)
Thu, Sep 3, 6:05 AM
Subscribers

Details

Summary

Address review comments from the initial SR-IOV support patch.

This change includes the following updates:

  • Rename the P7 VF PCI ID macro from NETXTREME_E_P7_VF to E_P7_VF, since the P7/Thor2 product strings no longer use the NetXtreme name. Other VF device IDs are unchanged.
  • Make bnxt_vf_parse_schema() return a boolean value and use that return value in bnxt_iov_vf_add() to decide whether bnxt_set_vf_admin_mac() should be called. This also removes the separate has_admin_mac field.
  • Fix indentation in bnxt_free_vf_resources() after dma_free_coherent(), so the NULL assignment is clearly separate from the function call.
  • Update bnxt_hwrm_func_vf_resource_free() to use first_vf_id and last_vf_id while looping through HWRM_FUNC_VF_RESC_FREE.

This patch addresses the code review comments provided for:
https://reviews.freebsd.org/D56197

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable