audio/lastfm-desktop: Update to 2.1.36
ClosedPublic
Actions

Authored by woodsb02 on Jun 16 2016, 10:54 PM.

Details

Reviewers

adamw
• vg
koobs
mat

Commits

rP418001: audio/lastfm-desktop: Update to 2.1.36

Summary

audio/lastfm-desktop: Update to 2.1.36

Move to official GitHub repo, since the official CDN is out of date
Patch of LAV_Source.cpp renamed to follow file move, and updated to fix build with FFmpeg 3.0.x - obtained from ArchLinx [1]. Note that multimedia/ffmpeg is currently still on the 2.8.x branch, however this patch is backwards compatible with ffmpeg 2.8.x.
Patch of RadioService.cpp updated - obtained from ArchLinux [2].
Remove patch of podDevice_linux.cpp, as the change was upstreamed
Add additional dependencies to LIB_DEPENDS and USE_QT4 as found by new stage-qa script.
Ensure program will appear in desktop manager menus by installing icon and adding DESKTOP_ENTRIES.
Add the audio playback run dependencies, with the option of either VLC or GSTREAMER. WIthout one of these, it crashes upon run.
Remove the LD_LIBRARY_PATH, as it is no longer needed now that the lastfm-desktop binaries are statically linked to it's private libraries.
Also do not install the *.a static libraries, as they are not used by any other programs/ports and not needed by the lastfm-desktop binaries.
Install all of the files required by for the .css stylesheet to work.

[1] https://aur.archlinux.org/cgit/aur.git/tree/LAV_Source_fix.patch?h=lastfm
[2] https://aur.archlinux.org/cgit/aur.git/tree/cast-bug.patch?h=lastfm

Test Plan

poudriere testport audio/lastfm-desktop

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 4256
Build 4300: arc lint + arc unit

Event Timeline

woodsb02 updated this revision to Diff 17648.Jun 16 2016, 10:54 PM

woodsb02 retitled this revision from to audio/lastfm-desktop: Update to 2.1.36.

woodsb02 updated this object.

woodsb02 edited the test plan for this revision. (Show Details)

woodsb02 added reviewers: adamw, mat, koobs, • vg.

Approved, if vg is happy.

The switch to *.a seems odd. Are there other ports that depend on this one? If so, their LIB_DEPENDS lines will have to be changed. And they'll need PORTREVISION bumps every time this port gets updated so that they can statically relink against the new version.

If there are not any ports that depend on this one, then why install statically linked libraries at all?

This revision is now accepted and ready to land.Jun 16 2016, 11:03 PM

Change PORTNAME=lastfm-desktop, and cleanup all the things that you were coercing it into doing the right thing.

Also, I'm not sure going with .a is the right thing to do, it makes it impossible to know what software really uses it.

This revision now requires changes to proceed.Jun 16 2016, 11:16 PM

As a rule of the thumb, when you use USE_GITHUB, and you have to set WRKSRC, it means you're doing it wrong.

As per comment from mat, change PORTNAME=lastfm-desktop, and cleanup all the
things that you were coercing it into doing the right thing.

Regarding the switch from *.so to *.a, this was not a change in the port, but
a change made by upstream here:
https://github.com/lastfm/lastfm-desktop/commit/a6d2225e368aaeb66ec5345717120013b40f2518

There are no other ports that depend on this one or use these shared libraries,
and the libraries are installed in DATADIR rather than lib/, meaning they are
intended to be private for lastfm-scrobbler binary.

I don't understand the LD_LIBRARY_PATH thing, there are no .so installed any more, so nothing the dynamic linker will need to load.

As per comment from mat, the LD_LIBRARY_PATH is no longer needed now that the lastfm-desktop binaries are statically linked to it's private libraries.
Also do not install the *.a static libraries, as they are not used by any other programs/ports and not needed by the lastfm-desktop binaries.
Lastly, install all of the files required by for the .css stylesheet to work.

woodsb02 updated this object.Jun 30 2016, 7:04 AM

vg: any comment on this one? It's been 2 weeks for maintainer timeout. Thanks :)