Page MenuHomeFreeBSD
Differential D56506

printenv: Clean up
ClosedPublic
Actions

Authored by des on Apr 18 2026, 4:52 PM.
Tags
None
Referenced Files
F163292070: D56506.id175844.diff
Tue, Jul 21, 7:18 PM
F163224458: D56506.diff
Tue, Jul 21, 5:24 AM
Unknown Object (File)
Sat, Jul 18, 2:11 AM
Unknown Object (File)
Wed, Jul 15, 7:18 AM
Unknown Object (File)
Wed, Jul 15, 7:18 AM
Unknown Object (File)
Thu, Jul 2, 2:16 AM
Unknown Object (File)
Wed, Jul 1, 4:37 AM
Unknown Object (File)
Fri, Jun 26, 10:41 PM
View All 31 Files
Subscribers
imp
ngie

Details

Reviewers
ngie
Group Reviewers
tests
Commits
rGc28508198f3b: printenv: Clean up
rGabdf2a711cab: printenv: Clean up
Summary
  • Error out if more than one argument is given.
  • Check for stdio errors.
  • Clean up the code.
  • Clean up and expand the tests.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Apr 18 2026, 4:52 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 18 2026, 4:52 PM
des requested review of this revision.Apr 18 2026, 4:52 PM
Harbormaster completed remote builds in B72329: Diff 175844.Apr 18 2026, 4:52 PM
ngie accepted this revision.Apr 21 2026, 4:33 AM
ngie added a subscriber: ngie.
ngie added inline comments.
usr.bin/printenv/tests/printenv_test.sh
45

How about this instead? It might be a bit easier to read/understand.

87

Why pipe these commands to true?

This revision is now accepted and ready to land.Apr 21 2026, 4:33 AM
des marked 2 inline comments as done.Apr 21 2026, 6:08 AM
des added inline comments.
usr.bin/printenv/tests/printenv_test.sh
45

It also does not work.

87

To cause a write failure.

des marked 2 inline comments as done.Apr 21 2026, 6:08 AM
Closed by commit rGabdf2a711cab: printenv: Clean up (authored by des). · Explain WhyApr 22 2026, 8:20 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGabdf2a711cab: printenv: Clean up.
ngie mentioned this in D56505: ident: Clean up.Apr 22 2026, 5:52 PM
des added a commit: rGc28508198f3b: printenv: Clean up.Apr 25 2026, 5:12 PM

Revision Contents
Changeset List

PathSize
usr.bin/
printenv/
52 lines
tests/
70 lines

Diff 176078

View Options

usr.bin/printenv/printenv.c

Loading...
View Options

usr.bin/printenv/tests/printenv_test.sh

Loading...