Replace libc's call to pipe(2) with pipe2(2).
ClosedPublic
Actions

Authored by brooks on Jun 11 2016, 8:42 PM.

Details

Reviewers

peter
andrew

Commits

rS302092: Replace use of the pipe(2) system call with pipe2(2) with a zero flags

Summary

pipe2() with flags=0 is idential to pipe(), but the pipe() system call
abuses the fact that system calls return two registers to avoid the use of
copyout() making it hard to trace with dtrace (since the kernel ignores
the arguments) and requring a machine dependent assembly wrapper in libc
for each version.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4229
Build 4273: arc lint + arc unit

Event Timeline

brooks updated this revision to Diff 17523.Jun 11 2016, 8:42 PM

brooks retitled this revision from to Replace libc's call to pipe(2) with pipe2(2)..

brooks updated this object.

brooks edited the test plan for this revision. (Show Details)

brooks added reviewers: peter, andrew.

Herald added subscribers: emaste, imp. · View Herald TranscriptJun 11 2016, 8:42 PM

Does pipe.o need to be added to NOASM, or does t figure this out when pipe.c is in SRCS?

Add pipe.o to NOASM and fix a missing declaration.

It looks like NOASM wasn't required in my test tree because D6816 was applied. Now fixed.

andrew accepted this revision.Jun 17 2016, 11:27 AM

andrew edited edge metadata.

This revision is now accepted and ready to land.Jun 17 2016, 11:27 AM

Is this intended to be done for 11.0, or after?

In D6815#144317, @emaste wrote:

Is this intended to be done for 11.0, or after?

I'd like to squeeze it in for 11 so aarch64 and riscv can not support the syscall, but it's not critical. I need to test the result more thoroughly before I can propose it.

Closed by commit rS302092: Replace use of the pipe(2) system call with pipe2(2) with a zero flags (authored by brooks). · Explain WhyJun 22 2016, 9:11 PM

This revision was automatically updated to reflect the committed changes.