Page MenuHomeFreeBSD

printenv: Clean up
AcceptedPublic

Authored by des on Sat, Apr 18, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 19, 8:44 AM
Unknown Object (File)
Sun, Apr 19, 12:25 AM
Subscribers

Details

Reviewers
ngie
Group Reviewers
tests
Summary
  • Error out if more than one argument is given.
  • Check for stdio errors.
  • Clean up the code.
  • Clean up and expand the tests.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72329
Build 69212: arc lint + arc unit

Event Timeline

des requested review of this revision.Sat, Apr 18, 4:52 PM
ngie added a subscriber: ngie.
ngie added inline comments.
usr.bin/printenv/tests/printenv_test.sh
45

How about this instead? It might be a bit easier to read/understand.

87

Why pipe these commands to true?

This revision is now accepted and ready to land.Tue, Apr 21, 4:33 AM
des marked 2 inline comments as done.Tue, Apr 21, 6:08 AM
des added inline comments.
usr.bin/printenv/tests/printenv_test.sh
45

It also does not work.

87

To cause a write failure.

des marked 2 inline comments as done.Tue, Apr 21, 6:08 AM