sound: Make chn_reset() control flow clearer
ClosedPublic
Actions

Authored by christos on Apr 5 2026, 8:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jun 9, 10:19 AM

	Unknown Object (File)
	Wed, May 27, 11:09 AM

	Unknown Object (File)
	Tue, May 26, 6:16 AM

	Unknown Object (File)
	Tue, May 26, 6:09 AM

	Unknown Object (File)
	Mon, May 25, 4:04 AM

	Unknown Object (File)
	Mon, May 25, 4:02 AM

	Unknown Object (File)
	May 17 2026, 9:07 PM

	Unknown Object (File)
	May 17 2026, 9:02 PM

View All 29 Files

Subscribers

imp

Details

Reviewers

markj
emaste

Commits

rGf56d0868bac3: sound: Make chn_reset() control flow clearer
rG8007a78bfe1f: sound: Make chn_reset() control flow clearer

Summary

I think this is cleaner than playing around with return values.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71974
Build 68857: arc lint + arc unit

Event Timeline

christos created this revision.Apr 5 2026, 8:30 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 5 2026, 8:30 PM

christos requested review of this revision.Apr 5 2026, 8:30 PM

Harbormaster completed remote builds in B71974: Diff 174942.Apr 5 2026, 8:30 PM

markj accepted this revision.Apr 6 2026, 3:05 AM

This revision is now accepted and ready to land.Apr 6 2026, 3:05 AM

Closed by commit rG8007a78bfe1f: sound: Make chn_reset() control flow clearer (authored by christos). · Explain WhyApr 7 2026, 3:45 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG8007a78bfe1f: sound: Make chn_reset() control flow clearer.

christos added a commit: rGf56d0868bac3: sound: Make chn_reset() control flow clearer.Apr 14 2026, 10:32 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

channel.c

33 lines

Diff 174942

View Options

sys/dev/sound/pcm/channel.c

sound: Make chn_reset() control flow clearerClosedPublicActions