acpi_apm: Narrow scope of ACPI_LOCK
ClosedPublic
Actions

Authored by jhb on Mar 20 2026, 4:46 PM.

Details

Reviewers

jkim
markj

Commits

rG50c4b12485fe: acpi_apm: Narrow scope of ACPI_LOCK
rGa7cf142ba904: acpi_apm: Narrow scope of ACPI_LOCK
rGcc2715cf1f86: acpi_apm: Narrow scope of ACPI_LOCK

Summary

This lock doesn't need to be held across seldrain/knlist_destroy. It
is also redundant (and a bug) to hold it across knlist_add and
knlist_remove since it is the mutex for the knlist.

PR: 293901

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Mar 20 2026, 4:46 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 20 2026, 4:46 PM

jhb requested review of this revision.Mar 20 2026, 4:46 PM

Harbormaster completed remote builds in B71591: Diff 174023.Mar 20 2026, 4:46 PM

markj accepted this revision.Mar 21 2026, 2:25 AM

markj added inline comments.

sys/x86/acpica/acpi_apm.c
413–414	I guess an alternate solution would be to make the last parameter 1 instead of 0? But I don't see much reason to acquire the lock here anyway.

This revision is now accepted and ready to land.Mar 21 2026, 2:25 AM

Closed by commit rGcc2715cf1f86: acpi_apm: Narrow scope of ACPI_LOCK (authored by jhb). · Explain WhyMar 30 2026, 1:41 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGcc2715cf1f86: acpi_apm: Narrow scope of ACPI_LOCK.

jhb added a commit: rGa7cf142ba904: acpi_apm: Narrow scope of ACPI_LOCK.Fri, Apr 24, 5:57 PM

jhb added a commit: rG50c4b12485fe: acpi_apm: Narrow scope of ACPI_LOCK.Fri, Apr 24, 7:54 PM