This is effectively a no-op, as it does not make use of the
sndcard_func->varinfo field, so eventually ua_probe() always succeeds.
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 71817 Build 68700: arc lint + arc unit
Event Timeline
| sys/dev/sound/usb/uaudio_pcm.c | ||
|---|---|---|
| 193 | Why did you change from BUS_PROBE_DEFAULT to 0? | |
| sys/dev/sound/usb/uaudio_pcm.c | ||
|---|---|---|
| 193 | This is the pcm driver, it does not correspond to a real device, but to a sound(4) device. Other drivers do the same already. Is there a reason to have BUS_PROBE_DEFAULT in this case? | |
| sys/dev/sound/usb/uaudio_pcm.c | ||
|---|---|---|
| 193 | Correction, not "correspond", but "probe". | |
| sys/dev/sound/usb/uaudio_pcm.c | ||
|---|---|---|
| 193 | I don't see a reason not to use 0 now that I see that ua_pcm devices are attached using bus_attach_children(), but the review description doesn't mention this change, so I can't easily see if it's intentional. | |
| sys/dev/sound/usb/uaudio_pcm.c | ||
|---|---|---|
| 193 | I'll update the description. Thanks :) | |