virtio_blk: Fix initialisation of dump request structure
ClosedPublic
Actions

Authored by sarah.walker2_arm.com on Mon, Mar 30, 9:21 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 11, 6:50 PM

	Unknown Object (File)
	Fri, Apr 10, 6:13 AM

	Unknown Object (File)
	Fri, Apr 10, 12:04 AM

	Unknown Object (File)
	Thu, Apr 9, 10:51 AM

	Unknown Object (File)
	Tue, Apr 7, 1:59 AM

	Unknown Object (File)
	Tue, Apr 7, 12:12 AM

	Unknown Object (File)
	Mon, Apr 6, 1:19 AM

	Unknown Object (File)
	Sun, Apr 5, 11:53 AM

View All 9 Files

Subscribers

imp

Details

Reviewers

andrew
asomers

Summary

Commit c8c37141 ("virtio_blk: Use bus_dma for command/ack buffer allocations")
failed to update initialisation of the dedicated dump request structure. This
caused a panic on attempting to dump core to a virtio_blk device.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71812
Build 68695: arc lint + arc unit

Event Timeline

sarah.walker2_arm.com created this revision.Mon, Mar 30, 9:21 AM

Herald added a subscriber: imp. · View Herald TranscriptMon, Mar 30, 9:21 AM

sarah.walker2_arm.com requested review of this revision.Mon, Mar 30, 9:21 AM

Harbormaster completed remote builds in B71812: Diff 174521.Mon, Mar 30, 9:21 AM

sarah.walker2_arm.com added reviewers: andrew, asomers.Mon, Mar 30, 9:22 AM

Works for me. Thanks for the fast fix.

This revision is now accepted and ready to land.Mon, Mar 30, 1:02 PM

andrew mentioned this in rGf54209510b1b: virtio_blk: Fix initialisation of dump request structure.Thu, Apr 9, 2:14 PM

Committed in rGf54209510b1b30b1445792db7d33401f7c7a97d6 with the wrong tag

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

block/

virtio_blk.c

94 lines

Diff 174521

View Options

sys/dev/virtio/block/virtio_blk.c

virtio_blk: Fix initialisation of dump request structureClosedPublicActions