Page MenuHomeFreeBSD
Differential D56085

kern_mib: remove kern.fallback_elf_brand compat sysctl
AcceptedPublic
Actions

Authored by chris.longros_gmail.com on Wed, Mar 25, 2:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 31, 6:10 PM
Unknown Object (File)
Mon, Mar 30, 8:55 PM
Unknown Object (File)
Mon, Mar 30, 3:57 PM
Unknown Object (File)
Sat, Mar 28, 3:36 PM
Unknown Object (File)
Fri, Mar 27, 9:37 AM
Subscribers
imp
olce

Details

Reviewers
kib
Summary

This compatibility alias for kern.elf{32,64}.fallback_brand has been
marked for removal since FreeBSD 6.0.

Signed-off-by: Christos Longros <chris.longros@gmail.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71725
Build 68608: arc lint + arc unit

Event Timeline

chris.longros_gmail.com created this revision.Wed, Mar 25, 2:06 PM
Herald added subscribers: olce, imp. · View Herald TranscriptWed, Mar 25, 2:06 PM
chris.longros_gmail.com requested review of this revision.Wed, Mar 25, 2:06 PM
Harbormaster completed remote builds in B71716: Diff 174293.Wed, Mar 25, 2:06 PM
chris.longros_gmail.com added a reviewer: kib.Wed, Mar 25, 2:09 PM
kib added a comment.Wed, Mar 25, 10:12 PM

Does the extern declaration for __elfN(fallback_brand) in sys/sys/imgact_elf.h is needed after the patch? Could the __elfN(fallback_brand) var made static in kern_elf.c?

chris.longros_gmail.com added a comment.EditedThu, Mar 26, 6:46 PM

Good point. Updated the made __elfN(fallback_brand) from extern to static in imgact_elf.c.

chris.longros_gmail.com updated this revision to Diff 174344.EditedThu, Mar 26, 6:47 PM

make fallback_brand static, remove extern

Harbormaster completed remote builds in B71725: Diff 174344.Thu, Mar 26, 6:47 PM
kib accepted this revision.Fri, Mar 27, 2:04 AM
This revision is now accepted and ready to land.Fri, Mar 27, 2:04 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines
6 lines
sys/
1 line
tools/
tools/
sysdoc/
3 lines

Diff 174344

View Options

sys/kern/imgact_elf.c

Loading...
View Options

sys/kern/kern_mib.c

Loading...
View Options

sys/sys/imgact_elf.h

Loading...
View Options

tools/tools/sysdoc/tunables.mdoc

Loading...