newfs: Don't combine GEOM journaling with SU
ClosedPublic
Actions

Authored by des on Fri, Mar 20, 7:48 PM.

Details

Reviewers

mckusick

Commits

rGe30fcdaae2e6: newfs: Don't combine GEOM journaling with SU

Summary

GEOM journaling shouldn't be used at the same time as soft updates, so
don't enable soft updates if GEOM journaling has been requested, and
error out if both are explicitly requested.

MFC after: 1 week
PR: 293896
Fixes: 61dece6d27fb ("Enable soft updates by default for UFS2 filesystems.")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71596
Build 68479: arc lint + arc unit

Event Timeline

des created this revision.Fri, Mar 20, 7:48 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Mar 20, 7:48 PM

des requested review of this revision.Fri, Mar 20, 7:48 PM

Harbormaster completed remote builds in B71596: Diff 174037.Fri, Mar 20, 7:48 PM

des edited the summary of this revision. (Show Details)Fri, Mar 20, 7:49 PM

Looks good. Not clear that soft updates and GEOM will not work at cross purposes with each other..

This revision is now accepted and ready to land.Fri, Mar 20, 9:55 PM

update manual page

This revision now requires review to proceed.Fri, Mar 20, 10:26 PM

Herald added a subscriber: ziaee. · View Herald TranscriptFri, Mar 20, 10:26 PM

Harbormaster completed remote builds in B71599: Diff 174041.Fri, Mar 20, 10:26 PM

correct date

Harbormaster completed remote builds in B71601: Diff 174043.Fri, Mar 20, 10:27 PM

In D55999#1280819, @mckusick wrote:

Not clear that soft updates and GEOM will not work at cross purposes with each other..

Fwiw the gjournal(8) manual page has always (since 2007) recommended not combining GEOM journaling with soft updates, so this should not come as a surprise.