Page MenuHomeFreeBSD
Differential D55985

ufshci: add uic powermode parameter to sysctl
ClosedPublic
Actions

Authored by jaeyoon on Mar 20 2026, 7:23 AM.
Tags
None
Referenced Files
F163795880: D55985.id.diff
Sun, Jul 26, 2:48 AM
F163680278: D55985.id174272.diff
Sat, Jul 25, 10:15 AM
Unknown Object (File)
Thu, Jul 23, 10:31 PM
Unknown Object (File)
Tue, Jul 21, 12:38 PM
Unknown Object (File)
Sun, Jul 19, 4:33 PM
Unknown Object (File)
Wed, Jul 15, 7:14 AM
Unknown Object (File)
Wed, Jul 15, 7:14 AM
Unknown Object (File)
Tue, Jul 14, 5:00 AM
View All 53 Files
Subscribers
ziaee

Details

Reviewers
imp
Commits
rG085028463fa9: ufshci: add uic powermode parameter to sysctl
Summary

Adds parameters related to the performance of the UFS device.

Sponsored by: Samsung Electronics

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71577
Build 68460: arc lint + arc unit

Event Timeline

jaeyoon requested review of this revision.Mar 20 2026, 7:23 AM
jaeyoon created this revision.
Harbormaster completed remote builds in B71577: Diff 173995.Mar 20 2026, 7:23 AM
jaeyoon added a parent revision: D55984: ufshci: fix bug in ufshci_req_sdb_enable.Mar 20 2026, 7:24 AM
jaeyoon added a child revision: D55986: ufshci: Support ACPI.
imp accepted this revision.Mar 20 2026, 1:39 PM

Is there documentation that needs to be updated?
The change itself looks good, though maybe the commit message is a little vague?

sys/dev/ufshci/ufshci_pci.c
37

I don't think you want this change...

This revision is now accepted and ready to land.Mar 20 2026, 1:39 PM
jaeyoon updated this revision to Diff 174145.Mar 23 2026, 2:36 AM

Modified the man page.

This revision now requires review to proceed.Mar 23 2026, 2:36 AM
Herald added a subscriber: ziaee. · View Herald TranscriptMar 23 2026, 2:36 AM
Harbormaster completed remote builds in B71657: Diff 174145.Mar 23 2026, 2:36 AM
jaeyoon added a comment.Mar 23 2026, 6:09 AM

Could you please approve this patch?

imp accepted this revision.Mar 23 2026, 2:25 PM
This revision is now accepted and ready to land.Mar 23 2026, 2:25 PM
jaeyoon marked an inline comment as done.Mar 24 2026, 12:18 AM
jaeyoon added inline comments.
sys/dev/ufshci/ufshci_pci.c
37

Clang-format enforces this awkward indentation.

imp added a comment.Mar 24 2026, 8:58 PM

OK. thanks for the info on clang-format. It's approved to commit.

Closed by commit rG085028463fa9: ufshci: add uic powermode parameter to sysctl (authored by jaeyoon). · Explain WhyMar 25 2026, 4:47 AM
This revision was automatically updated to reflect the committed changes.
jaeyoon marked an inline comment as done.
jaeyoon added a commit: rG085028463fa9: ufshci: add uic powermode parameter to sysctl.

Revision Contents
Changeset List

PathSize
sys/
dev/
ufshci/
12 lines
3 lines
3 lines
25 lines

Diff 173995

View Options

sys/dev/ufshci/ufshci_dev.c

Loading...
View Options

sys/dev/ufshci/ufshci_pci.c

Loading...
View Options

sys/dev/ufshci/ufshci_private.h

Loading...
View Options

sys/dev/ufshci/ufshci_sysctl.c

Loading...