amd64: check that %cs and %ss values from ucontext fit into registers
ClosedPublic
Actions

Authored by kib on Sun, Mar 15, 7:20 AM.

Details

Reviewers

jhb
markj

Commits

rG8892176c86db: amd64: check that %cs and %ss values from ucontext fit into registers

Summary

This change only checks that the values from the user-supplied context
are not truncated by C implicit type convertions.  The validity of the
segment selectors is still checked by hardware.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Sun, Mar 15, 7:20 AM

Herald added a subscriber: imp. · View Herald TranscriptSun, Mar 15, 7:20 AM

kib requested review of this revision.Sun, Mar 15, 7:20 AM

jhb accepted this revision.Thu, Mar 19, 2:39 PM

This revision is now accepted and ready to land.Thu, Mar 19, 2:39 PM

kib mentioned this in D55831: x86 FRED: add hardware definitions for the trap frames fields.Thu, Mar 19, 3:28 PM

markj added inline comments.Fri, Mar 20, 2:33 AM

sys/amd64/amd64/exec_machdep.c
275	These fields are register_t, which is signed.
sys/amd64/ia32/ia32_signal.c
217	... here, the fields are unsigned.

Centralize and fix checks.

This revision now requires review to proceed.Fri, Mar 20, 3:13 AM

markj added inline comments.Fri, Mar 20, 3:16 AM

sys/amd64/ia32/ia32_signal.c
721	This should be updated too?

Missed check.

markj accepted this revision.Fri, Mar 20, 4:57 AM

This revision is now accepted and ready to land.Fri, Mar 20, 4:57 AM

Closed by commit rG8892176c86db: amd64: check that %cs and %ss values from ucontext fit into registers (authored by kib). · Explain WhyFri, Mar 20, 10:50 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG8892176c86db: amd64: check that %cs and %ss values from ucontext fit into registers.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

exec_machdep.c

19 lines

ia32/

ia32_signal.c

28 lines

Diff 173976

View Options

sys/amd64/amd64/exec_machdep.c