llvm: Link cross-tools with static libllvm.a
ClosedPublic
Actions

Authored by emaste on Thu, Mar 19, 2:06 AM.

Details

Reviewers

dim
jrtc27

Group Reviewers

build

Commits

rGd478715a7289: llvm: Link cross-tools with static libllvm.a

Summary

TOOLS_PREFIX is set during the cross-tools build; use this to link cross
tools against the static llvm lib.  This logic existed in existing cross
tools (either via clang.prog.mk or bespoke rules) but was missing from
llvm.prog.mk.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Thu, Mar 19, 2:06 AM

emaste created this revision.

emaste added a child revision: D55923: build: Boostrap LLVM_BINUTILS for cross-tools.

Hm, at first I was confused because TOOLS_PREFIX seems to be tested in the first .if statement, but that is only for the tblgen tools. But LGTM.

usr.bin/clang/llvm.prog.mk
17	Hm, at first I was confused because TOOLS_PREFIX seems to be tested in the first .if statement, but that is only for the tblgen tools.

This revision is now accepted and ready to land.Thu, Mar 19, 9:39 AM

Closed by commit rGd478715a7289: llvm: Link cross-tools with static libllvm.a (authored by emaste). · Explain WhyThu, Mar 19, 1:18 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGd478715a7289: llvm: Link cross-tools with static libllvm.a.

Herald added a subscriber: imp. · View Herald TranscriptThu, Mar 19, 1:18 PM

emaste added inline comments.Thu, Mar 19, 6:02 PM

usr.bin/clang/llvm.prog.mk
17	Yeah, and after reading your comment I realized my commit message was incorrect. Will update for commit.

Revision Contents
Changeset List

Path

Size

usr.bin/

clang/

llvm.prog.mk

2 lines

Diff 173892

View Options

usr.bin/clang/llvm.prog.mk

llvm: Link cross-tools with static libllvm.aClosedPublicActions