linuxkpi: Define `MIN_T()` and `MAX_T()`
ClosedPublic
Actions

Authored by dumbbell on Sun, Mar 8, 1:26 PM.

Details

Reviewers

emaste
bz

Group Reviewers

linuxkpi

Commits

rGece26db020db: linuxkpi: Define `MIN_T()` and `MAX_T()`

Summary

There are the same as MIN() and MAX() except that they take a type to cast both arguments to compare.

The DRM generic code started to use it in Linux 6.11.

This is part of the update of DRM drivers to Linux 6.11.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Sun, Mar 8, 1:26 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptSun, Mar 8, 1:26 PM

dumbbell requested review of this revision.Sun, Mar 8, 1:26 PM

I think we want ()s
Considering uses like MIN_T(int, a - b, a + b)

sys/compat/linuxkpi/common/include/linux/minmax.h
63

Use parenthesis as suggested by @emaste.

dumbbell marked an inline comment as done.Sun, Mar 8, 8:57 PM

emaste accepted this revision.Mon, Mar 9, 1:13 AM

This revision is now accepted and ready to land.Mon, Mar 9, 1:13 AM

bz accepted this revision.Mon, Mar 9, 7:39 AM

Closed by commit rGece26db020db: linuxkpi: Define `MIN_T()` and `MAX_T()` (authored by dumbbell). · Explain WhyMon, Apr 6, 7:56 PM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rGece26db020db: linuxkpi: Define `MIN_T()` and `MAX_T()`.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

minmax.h

3 lines

Diff 173389

View Options

sys/compat/linuxkpi/common/include/linux/minmax.h

linuxkpi: Define `MIN_T()` and `MAX_T()`ClosedPublicActions