Page MenuHomeFreeBSD
Differential D55743

rge: use C style comments instead of C++
ClosedPublic
Actions

Authored by chris.longros_gmail.com on Mar 8 2026, 3:35 PM.
Tags
Referenced Files
F151532305: D55743.diff
Thu, Apr 9, 1:34 AM
Unknown Object (File)
Mon, Apr 6, 7:54 PM
Unknown Object (File)
Sun, Apr 5, 8:48 AM
Unknown Object (File)
Sat, Apr 4, 2:06 PM
Unknown Object (File)
Sat, Apr 4, 10:41 AM
Unknown Object (File)
Thu, Apr 2, 3:28 PM
Unknown Object (File)
Thu, Mar 26, 1:22 AM
Unknown Object (File)
Mon, Mar 23, 8:36 AM
View All 17 Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rG9976cff55e88: rge: use C style comments instead of C++
Summary

FreeBSD style(9) mandates C style comments. The initial import from
OpenBSD left several C++ style // comments in if_rge.c and if_rgevar.h.
Replace them with proper /* */ comments.

Also fix a malformed comment that mixed // with a closing */.

Signed-off-by: Christos Longros <chris.longros@gmail.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71261
Build 68144: arc lint + arc unit

Event Timeline

chris.longros_gmail.com created this revision.Mar 8 2026, 3:35 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 8 2026, 3:35 PM
Harbormaster completed remote builds in B71261: Diff 173365.Mar 8 2026, 3:35 PM
chris.longros_gmail.com requested review of this revision.Mar 8 2026, 3:35 PM
chris.longros_gmail.com added a reviewer: adrian.
chris.longros_gmail.com added a project: network.Mar 8 2026, 8:06 PM
adrian added a comment.Sat, Mar 14, 9:37 PM

Lemme see which I can delete and which I need to keep and use.

I /think/ the commented out fields in if_rgevar.h can just be deleted. Would you mind just deleting those fields and resubmitting the diff?

Thanks!

chris.longros_gmail.com updated this revision to Diff 173708.EditedSun, Mar 15, 8:15 AM

I deleted the 4 commented-out struct members from if_rgevar.h (if_rxring, pci_intr_handle_t, pci_chipset_tag_t, pcitag_t).

adrian accepted this revision.Sun, Mar 15, 4:13 PM
This revision is now accepted and ready to land.Sun, Mar 15, 4:13 PM
Closed by commit rG9976cff55e88: rge: use C style comments instead of C++ (authored by chris.longros_gmail.com, committed by adrian). · Explain WhySun, Mar 15, 8:18 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG9976cff55e88: rge: use C style comments instead of C++.

Revision Contents
Changeset List

PathSize
sys/
dev/
rge/
4 lines
8 lines

Diff 173365

View Options

sys/dev/rge/if_rge.c

Loading...
View Options

sys/dev/rge/if_rgevar.h

Loading...