Details
- Reviewers
olce
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 71112 Build 67995: arc lint + arc unit
Event Timeline
| sys/x86/cpufreq/hwpstate_amd.c | ||
|---|---|---|
| 676–679 | It is removed so I mark it as done. | |
Some small changes to do. Main point is to preserve sysctl_cppc_dump_handler()'s goal which is to always query the hardware (and thus never rely on cached values).
| sys/x86/cpufreq/hwpstate_amd.c | ||
|---|---|---|
| 181–185 | CAPABILITY_1 is 64-bit (even if the upper 32-bits are reserved for the time being). This change should be done in another revision/commit. What is your goal here? IMO, it would be useful to create sysctl knobs exporting the capability bounds; we'll have to apply the same kind of workaround for an uninitialized/improperly initialized register as we are currently applying for min/max performance value (in enable_cppc_cb()). | |
| 338–339 | We really want sysctl_cppc_dump_handler() to always query CPUs and not use cache values (useful for debugging), which this change is in contradiction with, so please remove it, along with the noted related ones below. | |
| 355–356 | Same as above. | |
| 394 | Same as above. | |
| 968–969 | As the addition of caps1 in the softc, belongs to a separate commit. See the corresponding inline comment for more details. | |