ffs snapshots: pass valid args to vn_start_write
ClosedPublic
Actions

Authored by vangyzen on Feb 25 2026, 4:34 PM.

Tags

None

Referenced Files

	F172495871: D55512.id172697.diff
	Fri, Sep 18, 8:52 PM

	F172494107: D55512.id172687.diff
	Fri, Sep 18, 8:36 PM

	Unknown Object (File)
	Fri, Sep 18, 6:25 PM

	Unknown Object (File)
	Fri, Sep 11, 10:51 AM

	Unknown Object (File)
	Wed, Sep 9, 3:40 PM

	Unknown Object (File)
	Thu, Aug 27, 11:33 PM

	Unknown Object (File)
	Wed, Aug 26, 5:48 PM

	Unknown Object (File)
	Wed, Aug 26, 7:50 AM

Subscribers

Details

Reviewers

mjg

Commits

rG722fbfef0abb: ffs snapshots: pass valid args to vn_start_write

Summary

If the initial no-wait vn_start_write fails, we pass the old
PCATCH flag to the following sleepable vn_start_write.
Following a75d1ddd74, that flag should be V_PCATCH.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 70995
Build 67878: arc lint + arc unit

Event Timeline

vangyzen created this revision.Feb 25 2026, 4:34 PM

Herald added subscribers: dab, badger, imp. · View Herald TranscriptFeb 25 2026, 4:34 PM

vangyzen requested review of this revision.Feb 25 2026, 4:34 PM

Harbormaster completed remote builds in B70995: Diff 172687.Feb 25 2026, 4:34 PM

mjg accepted this revision.Feb 25 2026, 6:29 PM

This revision is now accepted and ready to land.Feb 25 2026, 6:29 PM

Closed by commit rG722fbfef0abb: ffs snapshots: pass valid args to vn_start_write (authored by vangyzen). · Explain WhyFeb 25 2026, 8:19 PM

This revision was automatically updated to reflect the committed changes.

vangyzen added a commit: rG722fbfef0abb: ffs snapshots: pass valid args to vn_start_write.

Revision Contents
Changeset List

Path

Size

sys/

ufs/

ffs/

ffs_snapshot.c

2 lines

Diff 172687

View Options

sys/ufs/ffs/ffs_snapshot.c

ffs snapshots: pass valid args to vn_start_writeClosedPublicActions