nvmf_che: Don't leak a socket if an error occurs finalizing the socket
ClosedPublic
Actions

Authored by jhb on Feb 24 2026, 8:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 12, 9:54 AM

	Unknown Object (File)
	Fri, Oct 9, 3:10 AM

	Unknown Object (File)
	Sat, Oct 3, 8:28 AM

	Unknown Object (File)
	Fri, Oct 2, 5:20 PM

	Unknown Object (File)
	Fri, Oct 2, 1:25 PM

	Unknown Object (File)
	Wed, Sep 30, 1:03 AM

	Unknown Object (File)
	Tue, Sep 29, 5:50 PM

	Unknown Object (File)
	Tue, Sep 29, 4:55 PM

View All 61 Files

Subscribers

imp

Details

Reviewers

Commits

rG505f381cb96e: nvmf_che: Don't leak a socket if an error occurs finalizing the socket

Summary

If soreserve() or sosetopt() (to set TCP_NODELAY) fails after claiming
the socket from the file descriptor, explicitly close the socket before
returning failure.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70971
Build 67854: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 24 2026, 8:20 PM

Herald added subscribers: ae, imp. · View Herald TranscriptFeb 24 2026, 8:20 PM

jhb requested review of this revision.Feb 24 2026, 8:20 PM

Harbormaster completed remote builds in B70971: Diff 172623.Feb 24 2026, 8:20 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 20 2026, 5:20 PM

Closed by commit rG505f381cb96e: nvmf_che: Don't leak a socket if an error occurs finalizing the socket (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG505f381cb96e: nvmf_che: Don't leak a socket if an error occurs finalizing the socket.

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

nvmf/

nvmf_che.c

1 line

Diff 172623

View Options

sys/dev/cxgbe/nvmf/nvmf_che.c

nvmf_che: Don't leak a socket if an error occurs finalizing the socketClosedPublicActions