Page MenuHomeFreeBSD

libfetch: Fail hard if interrupted while connecting
ClosedPublic

Authored by des on Fri, Feb 20, 7:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 1, 11:01 PM
Unknown Object (File)
Tue, Feb 24, 2:32 AM
Unknown Object (File)
Mon, Feb 23, 9:54 PM
Unknown Object (File)
Mon, Feb 23, 9:53 PM
Unknown Object (File)
Mon, Feb 23, 9:53 PM
Subscribers

Details

Summary

This fixes an issue where the first address that DNS returns is blocked
by a packet filter, so we hang for a while, then the user hits Ctrl-C,
interrupting connect(2), whereupon we move on to the next address, get
a connection, request the file, and return to fetch(1), which sees that
SIGINT was caught and bails.

Note that we make no attempt to enforce fetchTimeout in the connection
phase, and never have. It's feasible, but non-trivial, so we'll leave
it as an exercise for future us.

PR: 293312
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70828
Build 67711: arc lint + arc unit