nvmecontrol: Remove an incorrect use of PAGE_SIZE
ClosedPublic
Actions

Authored by andrew on Tue, Feb 17, 5:46 PM.

Details

Reviewers

imp
jhb

Commits

rGbfb7c81f93b5: nvmecontrol: Remove an incorrect use of PAGE_SIZE

Summary

The mdts value is in terms of the nvme page size, not the host page
size. On many architectures these are both 4k, however on arm64 it is
possible to build a system with the host page size of 16k.

Use NVME_MPS_SHIFT to get the correct nvme page shift.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70734
Build 67617: arc lint + arc unit

Event Timeline

andrew created this revision.Tue, Feb 17, 5:46 PM

Herald added a subscriber: dab. · View Herald TranscriptTue, Feb 17, 5:46 PM

andrew requested review of this revision.Tue, Feb 17, 5:46 PM

Harbormaster completed remote builds in B70734: Diff 172081.Tue, Feb 17, 5:46 PM

Nice catch

This revision is now accepted and ready to land.Tue, Feb 17, 7:34 PM

Closed by commit rGbfb7c81f93b5: nvmecontrol: Remove an incorrect use of PAGE_SIZE (authored by andrew). · Explain WhyWed, Feb 18, 3:16 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGbfb7c81f93b5: nvmecontrol: Remove an incorrect use of PAGE_SIZE.

Revision Contents
Changeset List

Path

Size

sbin/

nvmecontrol/

identify_ext.c

2 lines

Diff 172081

View Options

sbin/nvmecontrol/identify_ext.c

nvmecontrol: Remove an incorrect use of PAGE_SIZEClosedPublicActions