Page MenuHomeFreeBSD
Differential D51936

Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.cabal
AbandonedPublic
Actions

Authored by alven on Aug 16 2025, 9:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 11, 9:26 AM
Unknown Object (File)
Wed, Mar 11, 9:17 AM
Unknown Object (File)
Wed, Mar 11, 8:50 AM
Unknown Object (File)
Wed, Mar 11, 7:51 AM
Unknown Object (File)
Wed, Mar 11, 7:18 AM
Unknown Object (File)
Wed, Mar 11, 6:31 AM
Unknown Object (File)
Wed, Mar 11, 6:27 AM
Unknown Object (File)
Wed, Mar 11, 6:19 AM
View All 50 Files
Subscribers
None

Details

Reviewers
arrowd
db
yuri
vvd
alven
Group Reviewers
portmgr
Commits
R11:5b0c4143bf72: Uses/cabal.mk: Also create ${CABAL_HOME} before "cabal update"
R11:87a12423c243: Uses/cabal.mk: cd into WRKDIR before calling 'cabal update' during cabal-extract
R11:97c5391bc427: Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.cabal
Summary

Like we already do have in Mk/Uses/cargo.mk for Makefile.crates

  • Adopt www/hs-postgrest to this change in framework.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alven requested review of this revision.Aug 16 2025, 9:52 PM
alven created this revision.
Harbormaster completed remote builds in B66289: Diff 160438.Aug 16 2025, 9:52 PM
arrowd added a comment.Aug 18 2025, 5:53 AM

I find .modules part to be confusing. Rust names it .crates, so we probably should call it .cabal

Mk/Uses/cabal.mk
78
3) make make-use-cabal > Makefile.modules
vvd added a comment.Aug 18 2025, 11:30 AM
In D51936#1187640, @arrowd wrote:

I find .modules part to be confusing. Rust names it .crates, so we probably should call it .cabal

crate => crates
cabal => cabals

arrowd added a comment.Aug 18 2025, 11:41 AM

Cabal is a package manager name and a file format, so no, plural seems unfitting there.

alven added 1 blocking reviewer(s): portmgr.Aug 20 2025, 9:18 AM

Anyone from portmgr@: please come and help us with this simplest task... :)

alven retitled this revision from Mk/Uses/cabal.mk: support for USE_CABAL in separate Makefile.modules to Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.modules.Oct 7 2025, 3:15 PM
alven added a comment.Feb 17 2026, 6:43 AM

Up, please...

arrowd added a comment.Feb 17 2026, 6:49 AM

If you want an approval from me then I'd like to see the file named Makefile.cabal, not .modules.

alven retitled this revision from Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.modules to Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.cabal.Feb 17 2026, 7:11 AM
alven added 1 blocking reviewer(s): arrowd.
alven updated this revision to Diff 172053.Feb 17 2026, 7:12 AM

Use filename 'Makefile.cabal'

Harbormaster completed remote builds in B70725: Diff 172053.Feb 17 2026, 7:12 AM
alven marked an inline comment as done.Feb 17 2026, 7:12 AM
arrowd added inline comments.Feb 17 2026, 7:13 AM
Mk/Uses/cabal.mk
78

@alven What do you think about this comment? ^

arrowd accepted this revision.EditedFeb 17 2026, 7:18 AM

Given that you verified that this actually works, LGTM.

You can also adapt www/hs-postgrest to make use of this feature.

alven added a comment.Feb 17 2026, 7:23 AM

Thank you! What now?

Mk/Uses/cabal.mk
78

Was just a mistake you've repeated after me? :)
I've fixed it to what you like now. It was all that simple, yes? :)

alven edited the summary of this revision. (Show Details)Feb 17 2026, 7:46 AM
arrowd added a comment.Feb 17 2026, 7:50 AM

Macro shipit:

This revision was not accepted when it landed; it landed in state Needs Review.Feb 17 2026, 8:16 AM
Closed by commit R11:97c5391bc427: Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.cabal (authored by alven). · Explain Why
This revision was automatically updated to reflect the committed changes.
alven added a commit: R11:97c5391bc427: Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.cabal.
alven signed these changes with MFA.Feb 17 2026, 8:20 AM

Thank you! :)

alven signed these changes with MFA.Fri, Mar 20, 8:42 AM
alven reopened this revision.

This stopped to work with newer versions of cabal, which tends to parse Makefile.cabal as a common .cabal file:

Errors encountered when parsing cabal file ./Makefile.cabal:

Makefile.cabal:0:0: error:
"name" field missing

May we choose another file extension for it, please?

arrowd added a comment.Fri, Mar 20, 9:10 AM

How do I reproduce the problem?

alven added a comment.Fri, Mar 20, 10:08 AM
cd /usr/ports/default/www/hs-postgrest && make cabal-extract
arrowd added a comment.Fri, Mar 20, 2:35 PM

Fixed in 87a12423c24377eb05ab20aa44897ecd443c0f9e

alven added a comment.EditedFri, Mar 20, 3:16 PM

Thank you! It helped :) But still:

cd /usr/ports/default/textproc/hs-pandoc && make cabal-extract
cd: /usr/ports/default/textproc/hs-pandoc/work: No such file or directory
arrowd added a comment.Fri, Mar 20, 3:20 PM

Fixed too.

alven added a comment.Fri, Mar 20, 3:54 PM

Thank you! May I MFH it to 2026Q1?

arrowd added a comment.Fri, Mar 20, 4:16 PM

I don't see a point in doing this. You shouldn't run make cabal-extract and friends on quarerly branches.

alven added a comment.Fri, Mar 20, 4:19 PM

I meant this to help those running FreeBSD on quarterly tree instead of latest...

alven signed these changes with MFA.Fri, Mar 20, 4:32 PM
alven accepted this revision.

Well, OK: it's for development only (for updating the ports, not for building them).

alven abandoned this revision.Fri, Mar 20, 4:36 PM
alven added commits: R11:87a12423c243: Uses/cabal.mk: cd into WRKDIR before calling 'cabal update' during cabal-extract, R11:5b0c4143bf72: Uses/cabal.mk: Also create ${CABAL_HOME} before "cabal update".

Revision Contents
Changeset List

PathSize
Mk/
Uses/
6 lines
www/
hs-postgrest/
6 lines
Makefile.cabal
Makefile.modules

Diff 172055

View Options

Mk/Uses/cabal.mk

Loading...
View Options

www/hs-postgrest/Makefile

Loading...
View Options

www/hs-postgrest/Makefile.cabal

Loading...
View Options

www/hs-postgrest/Makefile.modules

Loading...