Page MenuHomeFreeBSD

Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.cabal
Needs ReviewPublic

Authored by alven on Aug 16 2025, 9:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 11, 9:26 AM
Unknown Object (File)
Wed, Mar 11, 9:17 AM
Unknown Object (File)
Wed, Mar 11, 8:50 AM
Unknown Object (File)
Wed, Mar 11, 7:51 AM
Unknown Object (File)
Wed, Mar 11, 7:18 AM
Unknown Object (File)
Wed, Mar 11, 6:31 AM
Unknown Object (File)
Wed, Mar 11, 6:27 AM
Unknown Object (File)
Wed, Mar 11, 6:19 AM
Subscribers
None

Details

Summary

Like we already do have in Mk/Uses/cargo.mk for Makefile.crates

  • Adopt www/hs-postgrest to this change in framework.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alven requested review of this revision.Aug 16 2025, 9:52 PM
alven created this revision.

I find .modules part to be confusing. Rust names it .crates, so we probably should call it .cabal

Mk/Uses/cabal.mk
78
3) make make-use-cabal > Makefile.modules

I find .modules part to be confusing. Rust names it .crates, so we probably should call it .cabal

crate => crates
cabal => cabals

Cabal is a package manager name and a file format, so no, plural seems unfitting there.

Anyone from portmgr@: please come and help us with this simplest task... :)

alven retitled this revision from Mk/Uses/cabal.mk: support for USE_CABAL in separate Makefile.modules to Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.modules.Oct 7 2025, 3:15 PM

If you want an approval from me then I'd like to see the file named Makefile.cabal, not .modules.

alven retitled this revision from Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.modules to Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.cabal.Feb 17 2026, 7:11 AM
alven added 1 blocking reviewer(s): arrowd.

Use filename 'Makefile.cabal'

Mk/Uses/cabal.mk
78

@alven What do you think about this comment? ^

Given that you verified that this actually works, LGTM.

You can also adapt www/hs-postgrest to make use of this feature.

Thank you! What now?

Mk/Uses/cabal.mk
78

Was just a mistake you've repeated after me? :)
I've fixed it to what you like now. It was all that simple, yes? :)

This revision was not accepted when it landed; it landed in state Needs Review.Feb 17 2026, 8:16 AM
This revision was automatically updated to reflect the committed changes.
alven signed these changes with MFA.Feb 17 2026, 8:20 AM

Thank you! :)

alven signed these changes with MFA.Fri, Mar 20, 8:42 AM
alven reopened this revision.

This stopped to work with newer versions of cabal, which tends to parse Makefile.cabal as a common .cabal file:

Errors encountered when parsing cabal file ./Makefile.cabal:

Makefile.cabal:0:0: error:
"name" field missing

May we choose another file extension for it, please?

How do I reproduce the problem?

cd /usr/ports/default/www/hs-postgrest && make cabal-extract