Page MenuHomeFreeBSD
Differential D51936

Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.cabal
ClosedPublic
Actions

Authored by alven on Aug 16 2025, 9:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 17, 6:40 PM
Unknown Object (File)
Tue, Feb 17, 6:39 PM
Unknown Object (File)
Nov 27 2025, 11:09 AM
Unknown Object (File)
Nov 21 2025, 4:20 AM
Unknown Object (File)
Nov 4 2025, 7:15 PM
Unknown Object (File)
Nov 4 2025, 7:13 PM
Unknown Object (File)
Nov 4 2025, 7:11 PM
Unknown Object (File)
Oct 29 2025, 6:41 AM
View All 25 Files
Subscribers
None

Details

Reviewers
arrowd
db
yuri
vvd
Group Reviewers
portmgr
Commits
R11:97c5391bc427: Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.cabal
Summary

Like we already do have in Mk/Uses/cargo.mk for Makefile.crates

  • Adopt www/hs-postgrest to this change in framework.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 70725
Build 67608: arc lint + arc unit

Event Timeline

alven requested review of this revision.Aug 16 2025, 9:52 PM
alven created this revision.
Harbormaster completed remote builds in B66289: Diff 160438.Aug 16 2025, 9:52 PM
arrowd added a comment.Aug 18 2025, 5:53 AM

I find .modules part to be confusing. Rust names it .crates, so we probably should call it .cabal

Mk/Uses/cabal.mk
78
3) make make-use-cabal > Makefile.modules
vvd added a comment.Aug 18 2025, 11:30 AM
In D51936#1187640, @arrowd wrote:

I find .modules part to be confusing. Rust names it .crates, so we probably should call it .cabal

crate => crates
cabal => cabals

arrowd added a comment.Aug 18 2025, 11:41 AM

Cabal is a package manager name and a file format, so no, plural seems unfitting there.

alven added 1 blocking reviewer(s): portmgr.Aug 20 2025, 9:18 AM

Anyone from portmgr@: please come and help us with this simplest task... :)

alven retitled this revision from Mk/Uses/cabal.mk: support for USE_CABAL in separate Makefile.modules to Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.modules.Oct 7 2025, 3:15 PM
alven added a comment.Tue, Feb 17, 6:43 AM

Up, please...

arrowd added a comment.Tue, Feb 17, 6:49 AM

If you want an approval from me then I'd like to see the file named Makefile.cabal, not .modules.

alven retitled this revision from Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.modules to Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.cabal.Tue, Feb 17, 7:11 AM
alven added 1 blocking reviewer(s): arrowd.
alven updated this revision to Diff 172053.Tue, Feb 17, 7:12 AM

Use filename 'Makefile.cabal'

Harbormaster completed remote builds in B70725: Diff 172053.Tue, Feb 17, 7:12 AM
alven marked an inline comment as done.Tue, Feb 17, 7:12 AM
arrowd added inline comments.Tue, Feb 17, 7:13 AM
Mk/Uses/cabal.mk
78

@alven What do you think about this comment? ^

arrowd accepted this revision.EditedTue, Feb 17, 7:18 AM

Given that you verified that this actually works, LGTM.

You can also adapt www/hs-postgrest to make use of this feature.

alven added a comment.Tue, Feb 17, 7:23 AM

Thank you! What now?

Mk/Uses/cabal.mk
78

Was just a mistake you've repeated after me? :)
I've fixed it to what you like now. It was all that simple, yes? :)

alven edited the summary of this revision. (Show Details)Tue, Feb 17, 7:46 AM
arrowd added a comment.Tue, Feb 17, 7:50 AM

Macro shipit:

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Feb 17, 8:16 AM
Closed by commit R11:97c5391bc427: Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.cabal (authored by alven). · Explain Why
This revision was automatically updated to reflect the committed changes.
alven added a commit: R11:97c5391bc427: Mk/Uses/cabal.mk: Support for USE_CABAL in separate Makefile.cabal.
alven signed these changes with MFA.Tue, Feb 17, 8:20 AM

Thank you! :)

Revision Contents
Changeset List

PathSize
Mk/
Uses/
6 lines

Diff 172053

View Options

Mk/Uses/cabal.mk

Loading...