Page MenuHomeFreeBSD
Differential D6672

libthr: Enhance PANIC() to format messages
ClosedPublic
Actions

Authored by cem on Jun 1 2016, 6:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 29, 11:41 PM
Unknown Object (File)
Wed, Oct 29, 10:42 PM
Unknown Object (File)
Tue, Oct 28, 1:16 AM
Unknown Object (File)
Tue, Oct 21, 7:55 PM
Unknown Object (File)
Tue, Oct 21, 7:27 PM
Unknown Object (File)
Tue, Oct 21, 7:19 PM
Unknown Object (File)
Tue, Oct 21, 6:41 PM
Unknown Object (File)
Tue, Oct 21, 7:32 AM
View All 90 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS301136: libthr: Use formatted PANIC()
rS301135: libthr: _thread_vprintf: Enhance support for %p, %#x
rS301134: libthr: Add vprintf variant of _thread_printf, formatted PANIC()
Summary

libthr: Add vprintf variant of _thread_printf, formatted PANIC()

libthr: _thread_vprintf: Enhance support for %p, %#x

libthr: Use formatted PANIC()

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4070
Build 4113: arc lint + arc unit

Event Timeline

cem updated this revision to Diff 17174.Jun 1 2016, 6:27 AM
cem retitled this revision from to libthr: Enhance PANIC() to format messages.
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added a reviewer: kib.
Herald added a subscriber: imp. · View Herald TranscriptJun 1 2016, 6:27 AM
kib accepted this revision.Jun 1 2016, 1:59 PM
kib edited edge metadata.
kib added inline comments.
lib/libthr/thread/thr_exit.c
184

Replace '2' by 'STDERR_FILENO', since the line is modified anyway.

This revision is now accepted and ready to land.Jun 1 2016, 1:59 PM
cem updated this revision to Diff 17184.Jun 1 2016, 2:56 PM
cem edited edge metadata.

Use STDERR_FILENO instead of 2.

This revision now requires review to proceed.Jun 1 2016, 2:56 PM
kib accepted this revision.Jun 1 2016, 3:09 PM
kib edited edge metadata.
This revision is now accepted and ready to land.Jun 1 2016, 3:09 PM
Closed by commit rS301134: libthr: Add vprintf variant of _thread_printf, formatted PANIC() (authored by cem). · Explain WhyJun 1 2016, 4:10 PM
This revision was automatically updated to reflect the committed changes.
cem marked an inline comment as done.

Revision Contents
Changeset List

PathSize
lib/
libthr/
thread/
2 lines
31 lines
23 lines
25 lines
7 lines

Diff 17184

View Options

lib/libthr/thread/thr_cond.c

Loading...
View Options

lib/libthr/thread/thr_exit.c

Loading...
View Options

lib/libthr/thread/thr_mutex.c

Loading...
View Options

lib/libthr/thread/thr_printf.c

Loading...
View Options

lib/libthr/thread/thr_private.h

Loading...