Differential D55262

diff: Tweak recursion tests
ClosedPublic
Actions

Authored by des on Feb 12 2026, 2:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 27, 11:40 PM

	Unknown Object (File)
	Mon, Apr 27, 2:26 PM

	Unknown Object (File)
	Mon, Apr 27, 1:59 PM

	Unknown Object (File)
	Fri, Apr 24, 9:30 PM

	Unknown Object (File)
	Sun, Apr 19, 5:18 PM

	Unknown Object (File)
	Thu, Apr 16, 1:57 AM

	Unknown Object (File)
	Mar 23 2026, 6:31 PM

	Unknown Object (File)
	Mar 15 2026, 10:29 PM

View All 26 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGf10da155fafa: diff: Tweak recursion tests
rGb9a6888b37cc: diff: Tweak recursion tests
rG608d3c746d1b: diff: Tweak recursion tests
rGb2532432971f: diff: Tweak recursion tests

Summary

The -r flag is not required to compare two directories; it is only
required to compare them recursively, i.e. descend into their common
subdirectories. Adjust tests that use -r needlessly, and adjust the
dirloop test to verify that these two cases remain distinct.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70644
Build 67527: arc lint + arc unit

Event Timeline

des created this revision.Feb 12 2026, 2:27 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 12 2026, 2:27 PM

des requested review of this revision.Feb 12 2026, 2:27 PM

Harbormaster completed remote builds in B70644: Diff 171824.Feb 12 2026, 2:27 PM

des added a parent revision: D55261: diff: Tweak range of -C and -U arguments.Feb 12 2026, 2:37 PM

kevans accepted this revision.Feb 13 2026, 8:11 PM

This revision is now accepted and ready to land.Feb 13 2026, 8:11 PM

Closed by commit rGb2532432971f: diff: Tweak recursion tests (authored by des). · Explain WhyFeb 13 2026, 8:19 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGb2532432971f: diff: Tweak recursion tests.

des added a commit: rG608d3c746d1b: diff: Tweak recursion tests.Feb 18 2026, 12:26 AM

des added a commit: rGb9a6888b37cc: diff: Tweak recursion tests.

des added a commit: rGf10da155fafa: diff: Tweak recursion tests.

Revision Contents
Changeset List

Path

Size

usr.bin/

diff/

tests/

30 lines

Diff 171824

usr.bin/diff/tests/diff_test.sh

Loading...