Page MenuHomeFreeBSD
Differential D55248

diff: Improve directory loop detection
ClosedPublic
Actions

Authored by des on Wed, Feb 11, 2:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 20, 6:32 AM
Unknown Object (File)
Thu, Feb 19, 10:54 PM
Unknown Object (File)
Tue, Feb 17, 6:32 PM
Unknown Object (File)
Tue, Feb 17, 9:54 AM
Unknown Object (File)
Tue, Feb 17, 7:17 AM
Unknown Object (File)
Tue, Feb 17, 7:17 AM
Unknown Object (File)
Tue, Feb 17, 7:17 AM
Unknown Object (File)
Sun, Feb 15, 5:53 PM
View All 16 Files
Subscribers
imp

Details

Reviewers
kevans
Group Reviewers
Klara
Commits
rG74e3453b9051: diff: Improve directory loop detection
rG0c5c50353026: diff: Improve directory loop detection
rGf201382a551d: diff: Improve directory loop detection
rG71569594d860: diff: Improve directory loop detection
Summary

When we're done processing a directory, remove its entry from the tree
of visited inodes, ensuring that we only report a loop when we encounter
a descendant-to-ancestor link, not when we encounter a cousin-to-cousin
or sibling-to-sibling link.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70622
Build 67505: arc lint + arc unit

Event Timeline

des created this revision.Wed, Feb 11, 2:29 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, Feb 11, 2:29 PM
des requested review of this revision.Wed, Feb 11, 2:29 PM
Harbormaster completed remote builds in B70621: Diff 171762.Wed, Feb 11, 2:29 PM
kevans accepted this revision.Wed, Feb 11, 2:39 PM
This revision is now accepted and ready to land.Wed, Feb 11, 2:39 PM
des updated this revision to Diff 171763.Wed, Feb 11, 2:45 PM

move null check

This revision now requires review to proceed.Wed, Feb 11, 2:45 PM
Harbormaster completed remote builds in B70622: Diff 171763.Wed, Feb 11, 2:45 PM
kevans accepted this revision.Wed, Feb 11, 3:13 PM
This revision is now accepted and ready to land.Wed, Feb 11, 3:13 PM
Closed by commit rG71569594d860: diff: Improve directory loop detection (authored by des). · Explain WhyWed, Feb 11, 4:26 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG71569594d860: diff: Improve directory loop detection.
des added a commit: rGf201382a551d: diff: Improve directory loop detection.Sun, Feb 15, 8:58 AM
des added a commit: rG0c5c50353026: diff: Improve directory loop detection.
des added a commit: rG74e3453b9051: diff: Improve directory loop detection.

Revision Contents
Changeset List

PathSize
usr.bin/
diff/
20 lines
tests/
5 lines

Diff 171763

View Options

usr.bin/diff/diffdir.c

Loading...
View Options

usr.bin/diff/tests/diff_test.sh

Loading...